Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324926

Summary:	Multistage publish sometimes increments directory incorrectly
Product:	[WebTools] WTP Releng	Reporter:	David Williams <david_williams>
Component:	releng	Assignee:	David Williams <david_williams>
Status:	RESOLVED FIXED	QA Contact:	David Williams <david_williams>
Severity:	normal
Priority:	P3
Version:	3.10
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description David Williams

2010-09-10 02:52:54 EDT

Since publishing the build multiple times, it seems that sometimes it ends up publishing it to two locations ... one ends up complete, the other is missing tests and reports. Off hand, seems to happen most frequently "across midnight" but it'd be surprising if anything did any "time calculations". 
Probably caching two copies, or something. 

As a recent example, see 
http://build.eclipse.org/webtools/committers/wtp-R3.2.2-M/20100909185724/M-3.2.2-20100909185724/

and 

http://build.eclipse.org/webtools/committers/wtp-R3.2.2-M/20100909163939/M-3.2.2-20100909185724/

Odd thing is, the first one is correct in that directory name matches the timestamp in build id ... that's how it should be. But, it is missing the tests. The tests and reports get copied into the second one, which still has the right time stamp in buildid, but the directory is _lower_ in value! That's what makes me think it was computed earlier, and cached away in the wrong place. Not sure why it would happen sometimes, but not other times.

Comment 1 David Williams

2010-09-10 22:03:21 EDT

I cleaned up the script a little, but wasn't obvious why this "double publish" would happen (to two different time stamp directories). But ... there was some sloppy stuff in there (variables being set twice, cctimestamp being used, instead of timestamp, even though they should be exactly equal) .. so, maybe the cleanup will help. 

For reference, in full log file, search for 
label file:
which might be echo'd more than once, but should always be same value. 
And, 
cctimestamp
timestamp

These should be echo'd just once, per build, when the label.properties file is created. 

Also, I changed so label.properties file is "saved", copied to "site" directory. Besides sanity checking, that might be useful in making some of the php pages less variable or complex, and just read data from label.properties file? 

I've "released" the fix to the builder used for I builds ... should be safe to do so for maintenance at anytime, if no immediate problems.