Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324923

Summary:	Commit menu item locks user interface for a short period
Product:	[Technology] EGit	Reporter:	Bernard Leach <leachbj>
Component:	Core	Assignee:	Jens Baumgart <jens.baumgart>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	caniszczyk, mathias.kinzler, matthias.sohn, remy.suen
Version:	0.9.0
Target Milestone:	0.10.0-M1
Hardware:	PC
OS:	All
Whiteboard:

Description Bernard Leach

2010-09-10 01:39:19 EDT

Build Identifier: 20100218-1602

Using the nightly build;

Eclipse EGit (Incubation)	0.9.0.201009081513	org.eclipse.egit.feature.group

When I right click Team->Commit... there is a delay of approximately 7-10seconds before the commit diaglog is shown.  During this time the popup menu remains on the screen with the Commit... item selected.

The delay occurs regardless of if I select an individual resource or a directory.

Reproducible: Always

Steps to Reproduce:
1.Open a git based project
2.Right click on a resource
3.Select Team->Commit...

Comment 1 Remy Suen

2010-09-10 07:29:49 EDT

(In reply to comment #0)
> When I right click Team->Commit... there is a delay of approximately
> 7-10seconds before the commit diaglog is shown.  During this time the popup
> menu remains on the screen with the Commit... item selected.

Is your repository rather large (though I admit the adjective "large" is subjective)? If you try committing from a small repository, is it faster?

Comment 2 Chris Aniszczyk

2010-09-10 10:09:59 EDT

I experience this also... same in the tag dialog.

We need to perform a bit of a analysis of why things are locking up.

Comment 3 Chris Aniszczyk

2010-09-10 10:10:20 EDT

bumping to major

Comment 4 Remy Suen

2010-09-10 10:12:40 EDT

(In reply to comment #2)
> I experience this also... same in the tag dialog.
> 
> We need to perform a bit of a analysis of why things are locking up.

I would personally suspect the cause to be behind all the commit walking that is done for these dialogs to be populated.

Comment 5 Jens Baumgart

2010-09-20 03:33:26 EDT

Fix proposed: http://egit.eclipse.org/r/1634

Comment 6 Matthias Sohn

2010-09-23 19:12:56 EDT

merged as 1fc344e151da9716823bd5dd977a6a4d8782a69d

Now the UI isn't frozen anymore, instead a dialog shows the progress of walking the working tree.