Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324890

Summary: Build/packaging update for probekit on new platforms
Product: z_Archived Reporter: Mike Reid <mikereid>
Component: TPTPAssignee: Mike Reid <mikereid>
Status: CLOSED FIXED QA Contact: Kathy Chan <kathy>
Severity: major    
Priority: P2 CC: jcayne, jgwest
Version: unspecifiedFlags: kathy: pmc_approved? (oec)
kathy: pmc_approved? (ernest)
kathy: pmc_approved? (kathy)
jgwest: pmc_approved+
kathy: pmc_approved? (jerome.bozier)
Target Milestone: ---   
Hardware: PC   
OS: other   
Whiteboard:
Attachments:
Description Flags
Patch
none
Patch pt2 none

Description Mike Reid CLA 2010-09-09 14:53:52 EDT
This is to add needed .sf files in order to enable the probekit build on the new platforms (AIX, Solaris, zOS).
Comment 1 Mike Reid CLA 2010-09-10 16:02:14 EDT
Created attachment 178660 [details]
Patch

Attaching a patch which implements the required .sf files. 

Additionally some problems in the link and packaging steps were found on zOS. The attached patch includes changes to accommodate these issues as well.
Comment 2 Jonathan West CLA 2010-09-10 16:11:29 EDT
Patch is good.
Comment 3 Mike Reid CLA 2010-09-10 16:12:57 EDT
Requesting to bring this forward for PMR approval:

   1.   Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed?
   
   This fix is needed to build on newly supported downstream platforms.
   
   2. Is there a work-around? If so, why do you believe the work-around is insufficient?
   
   No.
   
   3. Is this a regression or API breakage? Explain.
   
   No.
   
   4. Does this require new API?
   
   No.
   
   5. Who performed the code review?
   
	Jonathan West, Sam Wu
   
   6. Is there a test case attached to the bugzilla record?
   
   n/a
   
   7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix?
   
   Build changes.
   
   8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard?

   No.
Comment 4 Kathy Chan CLA 2010-09-10 16:16:06 EDT
Requesting PMC approval for TPTP 4.7.1.

Note that these changes only affected the new platforms supporting the Agent Controller.  It does not affect the builds produced by TPTP.
Comment 5 Mike Reid CLA 2010-09-10 16:21:51 EDT
Patch checked into HEAD w/ PMC approval.
Comment 6 Mike Reid CLA 2010-09-13 19:14:58 EDT
Created attachment 178780 [details]
Patch pt2

Second patch checked in converting some files to UNIX newlines in order to be build correctly and correcting a typo in the original patch.
Comment 7 Kathy Chan CLA 2011-02-11 13:45:56 EST
This defect had been resolved as FIXED for more than 1 month.  Please verify with the latest TPTP 4.7.2 driver.  If this defect is still left unverified by February 25, we'll close it on the originator's behalf.

TPTP 4.7.2 driver can be downloaded from:

http://www.eclipse.org/tptp/home/downloads/?ver=4.7.2
Comment 8 Mike Reid CLA 2011-04-04 10:53:27 EDT
Closing.