Bugzilla – Full Text Bug Listing
| Summary: | Need to subclass CSourceHover | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Violaine Batthish <batthish> | ||||
| Component: | cdt-core | Assignee: | Vivian Kong <vivkong> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Doug Schaefer <cdtdoug> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | aleherb+eclipse, ankitp, recoskie, vivkong | ||||
| Version: | 7.0 | Flags: | aleherb+eclipse:
review+
|
||||
| Target Milestone: | 7.0.1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Other than the usual caveats about the dangers of subclassing internals, I don't really see a problem with making these things protected instead of private. Toni, do you have any thoughts? That's fine with me. Applied to HEAD and cdt_7_0. Thanks. *** cdt cvs genie on behalf of vkong *** Bug 324888 Need to subclass CSourceHover [*] CSourceHover.java 1.43.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/c/hover/CSourceHover.java?root=Tools_Project&r1=1.43&r2=1.43.2.1 [*] CSourceHover.java 1.44 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/c/hover/CSourceHover.java?root=Tools_Project&r1=1.43&r2=1.44 |
Created attachment 178545 [details] patch for protected methods I need to subclass CSourceHover, and I need for the following methods to be made protected so that I can add my code: SingletonRule ComputeSourceRunnable searchInIndex I have attached a patch