Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324873

Summary: [repository] Share IUs for Composite Repositories
Product: [Eclipse Project] Equinox Reporter: DJ Houghton <dj.houghton>
Component: p2Assignee: Dean Roberts <dean.t.roberts>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: dj.houghton, irbull, pascal
Version: 3.7Keywords: performance
Target Milestone: 3.7 M5Flags: dj.houghton: review+
Hardware: PC   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 329384, 333894    
Attachments:
Description Flags
Add ObjectPool to share IUs during CompositeRepository load
none
patch none

Description DJ Houghton CLA 2010-09-09 13:13:18 EDT 
Currently the way composite repositories are represented, they contain a collection of all their children and the children are loaded in full. 

Consider the case where we have a composite repository and its children contain only incrementally different IUs. (for instance, where we have a parent which represents the I-builds and each child is a different I-build, with some IUs remaining the same)

In this case there is an opportunity to avoid duplication... if the same IU exists in 4 children repositories then it could only exist once in memory.
Comment 1 Dean Roberts CLA 2010-12-02 14:37:58 EST 
Created attachment 184386 [details]
Add ObjectPool to share IUs during CompositeRepository load

This patch defines some new API which requires the bundle version for org.eclipse.equinox.p2.core to be incremented.  However, there are a large number of bundles that have very narrow requires ranges.  In addition these bundles also define both a requires and an import packages for the same bundle but with different version ranges.

John A. is posting some questions on the mailing list and is looking into this.  As such, the bundle version number change is not included in this patch.
Comment 2 DJ Houghton CLA 2011-01-19 16:41:30 EST 
Created attachment 187153 [details]
patch

Updated patch.
Comment 3 DJ Houghton CLA 2011-01-19 16:42:21 EST 
Patch released.