Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324810

Summary:	[block selection] specify a win7 font value for org.eclipse.ui.workbench.texteditor.blockSelectionModeFont
Product:	[Eclipse Project] Platform	Reporter:	Susan McCourt <susan>
Component:	Text	Assignee:	Markus Keller <markus.kell.r>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, dh_tue, markus.kell.r, michael.pellaton, nikolaymetchev, remy.suen
Version:	3.7
Target Milestone:	4.6 M7
Hardware:	PC
OS:	Windows 7
Whiteboard:	fix candidate
Bug Depends on:	324882
Bug Blocks:

Description Susan McCourt

2010-09-08 20:07:29 EDT

per bug 320616, we now have a win7 jface fonts file.
We specify "Consolas" as the default jface text font (see [1]).
The font definition in the themes extension point in org.eclipse.ui.workbench.texteditor should specify this same font when os="windows7"

[1] (from MS Consolas font pack)
Consolas is intended for use in programming environments and other circumstances where a monospaced font is specified. All characters have the same width, like old typewriters, making it a good choice for personal and business correspondence. Optimizing the font specifically for ClearType allowed a design with proportions closer to normal text than traditional monospaced fonts like Courier. This allows for more comfortable reading of extended text on-screen.

Comment 1 Markus Keller

2010-09-09 13:58:51 EDT

We can't fix this right now, see bug 324882. After that, the fix is to add:

         <fontValue
               os="win32"
               osName="Windows 7"
               value="Consolas-regular-10">
         </fontValue>

Comment 2 Markus Keller

2015-12-10 10:37:24 EST

*** Bug 346374 has been marked as a duplicate of this bug. ***

Comment 3 Markus Keller

2015-12-10 11:26:01 EST

Since all pre-Win7 OSes are out of support, we could safely change the default for win32 to Consolas-regular-10 now.

But the right solution is to remove the platform-specific font definitions and use an AbstractPreferenceInitializer to set the default value for the blockSelectionModeFont to the default value of JFaceResources.TEXT_FONT.

Comment 4 Markus Keller

2016-04-21 13:52:11 EDT

(In reply to Markus Keller from comment #3)
> Since all pre-Win7 OSes are out of support, we could safely change the
> default for win32 to Consolas-regular-10 now.

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=579ff36747d2c917fc9edc055a8ce753284c2f4c

> But the right solution is to remove the platform-specific font definitions
> and use an AbstractPreferenceInitializer to set the default value for the
> blockSelectionModeFont to the default value of JFaceResources.TEXT_FONT.

Keeping the bug open for that.

Comment 5 Dani Megert

2016-04-22 08:52:12 EDT

(In reply to Markus Keller from comment #4)
> > But the right solution is to remove the platform-specific font definitions
> > and use an AbstractPreferenceInitializer to set the default value for the
> > blockSelectionModeFont to the default value of JFaceResources.TEXT_FONT.
> 
> Keeping the bug open for that.

Filed bug 492247 for that.