Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324798

Summary:

make task deactivation use a command

Product:

z_Archived

Reporter:

Sam Davis <sam.davis>

Component:

Mylyn

Assignee:

Steffen Pingel <steffen.pingel>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

shawn.minto

Version:

unspecified

Target Milestone:

3.4.2

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
mylyn/context/zip	none
fix	none
mylyn/context/zip	none

Description Sam Davis

2010-09-08 16:41:25 EDT

Task deactivation doesn't use a command, so it is not captured in the event stream.

Comment 1 Sam Davis

2010-09-08 16:42:20 EDT

Created attachment 178443 [details]
mylyn/context/zip

Comment 2 Shawn Minto

2010-09-08 16:55:55 EDT

Does this only happen when the task is deactivated from the task list?

Comment 3 Steffen Pingel

2010-09-08 17:25:33 EDT

Can you be more specific, Sam? The plugin.xml of o.e.m.tasks.ui specifies a command for deactivating the active task. The id is org.eclipse.mylyn.tasks.ui.command.deactivateSelectedTask .

Comment 4 Sam Davis

2010-09-08 18:04:06 EDT

The command is not used when deactivating the task by clicking the icon in the task list, nor when deactivating a task using the task editor.

Comment 5 Steffen Pingel

2010-09-08 18:13:36 EDT

Right, can you provide a patch that makes the appropriate changes to ToggleTaskActivationAction etc.? TasksUiInternal.activateTaskThroughCommand() has an example how to programatically invoke a command.

Comment 6 Sam Davis

2010-09-08 18:20:41 EDT

I'll look into it when I get a chance.

Comment 7 Steffen Pingel

2010-09-09 18:35:14 EDT

Created attachment 178575 [details]
fix

Comment 8 Steffen Pingel

2010-09-09 18:35:16 EDT

Created attachment 178576 [details]
mylyn/context/zip

Comment 9 Steffen Pingel

2010-09-09 18:37:32 EDT

Fixed in e_3_4_m_3_x and head. Task deactivation from the editor and task list should now be facilitated through the org.eclipse.mylyn.tasks.ui.command.deactivateSelectedTask command. Shawn, it woulc be nice if you could do a quick review when you get a chance.