Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324794

Summary: Custom Call back hook to compile jar-in-jar-loader.zip
Product: [Eclipse Project] JDT Reporter: Niels Thykier <niels>
Component: UIAssignee: Markus Keller <markus.kell.r>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: akurtakov, daniel_megert, markus.kell.r
Version: 3.7   
Target Milestone: 3.7 M3   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on:    
Bug Blocks: 319476    
Attachments:
Description Flags
custom callback hook
markus.kell.r: iplog+
Fix 2 none

Description Niels Thykier CLA 2010-09-08 16:22:22 EDT 
Build Identifier: Irrelevant

Hi

In eclipse-build (subproject of LinuxTools) we attempt to recompile eclipse completely from source. As a part of that we also want to regenerate jar-in-jar-loader.zip; to do this we have generated a custom callback hook and was wondering if you would accept it into the jdt.ui build tree.

~Niels


Reproducible: Always
Comment 1 Niels Thykier CLA 2010-09-08 16:26:45 EDT 
Created attachment 178440 [details]
custom callback hook

This callback hook will auto-regenerate jar-in-jar-loader.zip if it is missing. It can be extended to always regeneratign jar-in-jar-loader.zip from source (e.g. by removing jar-in-jar-loader.zip in the clean target).

~Niels
Comment 2 Markus Keller CLA 2010-09-09 06:17:38 EDT 
We can release this, but I'd rather keep a compiled version of jar-in-jar-loader.zip in CVS and use that by default (so the custom callback hook is a no-op by default, unless someone else removes the zip).
Comment 3 Niels Thykier CLA 2010-09-09 10:05:31 EDT 
That would be great; we have a script to clean up the source tree before starting the build and adding jar-in-jar-loader.zip to its purge list is trivial for us. 

~Niels
Comment 4 Markus Keller CLA 2010-10-20 15:01:57 EDT 
Created attachment 181331 [details]
Fix 2

The original patch didn't work (wrong file name in the <available> test).
Comment 5 Markus Keller CLA 2010-10-20 15:02:55 EDT 
Fixed in HEAD.