Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324776

Summary: MOXy: SchemaGenerator addToSchemaType method needs to be broken apart
Product: z_Archived Reporter: David McCann <david.mccann>
Component: EclipselinkAssignee: Nobody - feel free to take it <nobody>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Contains proposed changes. none

Description David McCann CLA 2010-09-08 13:57:13 EDT 
The addToSchemaType method is over 550 lines long, which makes it very difficult to work with when adding new support or debugging issues.  This method needs to be cleaned up and broken apart into smaller, less verbose methods.

There are also one or more places where we check for a given annotation as opposed to asking the Property.  For XML metadata/annotation correctness we should be checking the property.
Comment 1 David McCann CLA 2010-09-09 11:10:57 EDT 
Created attachment 178523 [details]
Contains proposed changes.

1) Added constants for '@', "##default", etc.
2) Renamed inner class 'XmlPathResult' to 'AddToSchemaResult' and added a ComplexType attribute.
3) Cleaned up 'addToSchemaType' method - new methods were added at the end of the class.
Comment 2 David McCann CLA 2010-09-09 14:08:35 EDT 
Reviewed by:  blaise.doughan@oracle.com
Tests: all unit tests pass as expected
Comment 3 Eclipse Webmaster CLA 2022-06-09 10:24:02 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink