Bug 324738

Comment 1 Mathias Kinzler 2010-10-01 08:32:23 EDT

Code review at http://egit.eclipse.org/r/#change,1692

Comment 2 Remy Suen 2010-10-01 09:59:08 EDT

(In reply to comment #0)
> Instead of showing an error popup "File xxx does not exist in commit yyy",
> failure to "Open" a file in the history view should open an error editor
> (hopefully re-usable) showing the error message. This is less distracting to
> the user.

I don't personally see the value in (re)using an editor or how a popup dialog is necessarily "distracting" to the user. I tried to do something, a popup tells me appears to tell me it failed, this all seems like a pretty standard way of reporting a failure to an end user.

Comment 3 Mathias Kinzler 2010-10-01 10:03:38 EDT

(In reply to comment #2)
> (In reply to comment #0)
> > Instead of showing an error popup "File xxx does not exist in commit yyy",
> > failure to "Open" a file in the history view should open an error editor
> > (hopefully re-usable) showing the error message. This is less distracting to
> > the user.
> 
> I don't personally see the value in (re)using an editor or how a popup dialog
> is necessarily "distracting" to the user. I tried to do something, a popup
> tells me appears to tell me it failed, this all seems like a pretty standard
> way of reporting a failure to an end user.

Well, isn't it what the IDE itself does if an editor can not be opened?

Comment 4 Remy Suen 2010-10-01 10:10:55 EDT

(In reply to comment #3)
> Well, isn't it what the IDE itself does if an editor can not be opened?

Which scenario are you talking about exactly? When I restart Eclipse and some of my opened files have been deleted? I had editors opened and I expect them to remain, that seems logical. No one wants to start Eclipse and have a popup appear showing a list of files that were previously opened but can no longer be found. I don't think these two scenarios are the same, unless you're referring to something else.

Comment 5 Mathias Kinzler 2010-10-01 10:15:24 EDT

(In reply to comment #4)
> (In reply to comment #3)
> > Well, isn't it what the IDE itself does if an editor can not be opened?
> 
> Which scenario are you talking about exactly? When I restart Eclipse and some
> of my opened files have been deleted? I had editors opened and I expect them to
> remain, that seems logical. No one wants to start Eclipse and have a popup
> appear showing a list of files that were previously opened but can no longer be
> found. I don't think these two scenarios are the same, unless you're referring
> to something else.

The scenario is when a PartInitException is thrown while initializing the editor. The PartInitException is not forwarded to the caller of openEditor, but instead an error editor is openend (see bug 90582 about the implications by the way).

Comment 6 Remy Suen 2010-10-01 10:27:12 EDT

(In reply to comment #5)
> The scenario is when a PartInitException is thrown while initializing the
> editor.

I guess my argument here is that we've actually clearly identified that the file is non-existent in CompareVersionsHandler and ShowVersionsHandler but we _still_ opt to show the editor. This isn't a case of the editor failing to initialize itself. This is a case of the client code having full knowledge of the fact that the editor cannot be opened (since the file doesn't actually exist) but still opting to show an error editor part instead of an error dialog.

Comment 7 Mathias Kinzler 2011-02-15 04:48:40 EST

Looks like no one wants this.