Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324734

Summary: new images for the overlay
Product: [WebTools] WTP ServerTools Reporter: Angel Vera <arvera>
Component: wst.serverAssignee: Angel Vera <arvera>
Status: CLOSED FIXED QA Contact: Angel Vera <arvera>
Severity: normal    
Priority: P3 CC: david_williams, kaloyan
Version: 3.2Flags: david_williams: pmc_approved+
arvera: pmc_approved? (raghunathan.srinivasan)
arvera: pmc_approved? (naci.dai)
arvera: pmc_approved? (deboer)
arvera: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+
Target Milestone: 3.2.2   
Hardware: PC   
OS: Windows XP   
See Also: https://git.eclipse.org/r/108994
Whiteboard: PMC_approved
Bug Depends on: 285186    
Bug Blocks:    
Attachments:
Description Flags
smaller icons none

Description Angel Vera CLA 2010-09-08 09:00:51 EDT
Created attachment 178399 [details]
smaller icons

The UI team has given me new images for the overlay of the state of a server. The images are slightly smaller than the originals due to input from usability.
Comment 1 Angel Vera CLA 2010-09-08 09:06:38 EDT
This is an improved set of icons from the changes in Bug# 285186.

* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 
This is not hotbug but based on usability analysis, it is better to have a smaller overlay icon to make the product more usable. 

* Is there a work-around? If so, why do you believe the work-around is insufficient? 
no

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
Manual testing

* Give a brief technical overview. Who has reviewed this fix? 
Angel, the changes are just to replace the current set of bigger icons with a smaller set of icons, the names of the icons are all the same.

* What is the risk associated with this fix? 
minimal, is binary check in replacing the old files with newer ones.
Comment 2 Kaloyan Raev CLA 2010-09-08 09:13:33 EDT
I am sure these icons are better than the existing ones. But do you really want to introduce this in a service release? It looks to me as a cosmetic change suitable for the 3.3 release. 

Are you really sure that such change will not affect the branding of any adopter?
Comment 3 Angel Vera CLA 2010-09-08 09:51:06 EDT
Kayolan, 
285185 as you probably are know, actually fixed the problem where the state icon (play, stop, debug, etc..) were too big and didn't allow for the adopters image to be displayed.

The icons in this bug are exactly the same as the old ones introduced in the fix for 285185 but smaller. One of the reason why we are making them smaller is to provide more space for the adopters image to be more visible.
Comment 4 Angel Vera CLA 2010-09-08 09:52:21 EDT
(In reply to comment #3) [correction to the bug number]
> Kayolan, 
> [Bug 285186] as you probably know, actually fixed the problem where the state
> icon (play, stop, debug, etc..) were too big and didn't allow for the adopters
> image to be displayed.
> 
> The icons in this bug are exactly the same as the old ones introduced in the
> fix for [Bug 285186] but smaller. One of the reason why we are making them smaller is
> to provide more space for the adopters image to be more visible.
Comment 5 Kaloyan Raev CLA 2010-09-08 09:55:22 EDT
Oh, OK. It was not clear to me that the problem in bug 285186 was because of icon overwriting. Now I see the real purpose of having these icons smaller.
Comment 6 Angel Vera CLA 2010-09-08 13:47:06 EDT
changes committed to 32M
Comment 7 Angel Vera CLA 2010-09-08 14:22:18 EDT
changes released to 32M
Comment 8 Angel Vera CLA 2010-09-08 14:45:07 EDT
changes committed to HEAD(3.3)
Comment 9 Angel Vera CLA 2010-09-08 14:48:43 EDT
changes released to HEAD(3.3)
Comment 10 Eclipse Genie CLA 2017-10-11 16:34:56 EDT
New Gerrit change created: https://git.eclipse.org/r/108994