Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324718

Summary: [formatter]Indentation-Combination of Concatenation and Function Arguments does not work as expected
Product: [Eclipse Project] JDT Reporter: Daniel Schaarschmidt <daniel.schaarschmidt>
Component: CoreAssignee: Mateusz Matela <mateusz.matela>
Status: VERIFIED DUPLICATE QA Contact:
Severity: normal    
Priority: P3 CC: amj87.iitr, frederic_fusier, jarthana, mateusz.matela, Olivier_Thomann
Version: 3.6   
Target Milestone: 4.11 M1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Sample Source
none
Formatter Settings none

Description Daniel Schaarschmidt CLA 2010-09-08 05:24:04 EDT
Build Identifier: 20100617-1415

The Formatter is set to indent by one expressions and arguments in function calls. Each of them seperately works as expected, but a combination of both in one statement should result in a deeper indentation, but it does not.

See the included Formatter-Settings and Sample Code. The first and second call to doSomething() are indented as expected, but the third should indent line 15 another time, because "bar" is a wrapped parameter in the Constructor-Call Container() which itself is part of an already indented line because of the wrapped concatenation in line 14.

Reproducible: Always

Steps to Reproduce:
1.Import the Formatter Settings and activate them
2.Open the Sample
3.Format it
Comment 1 Daniel Schaarschmidt CLA 2010-09-08 05:26:00 EDT
Created attachment 178375 [details]
Sample Source
Comment 2 Daniel Schaarschmidt CLA 2010-09-08 05:26:27 EDT
Created attachment 178376 [details]
Formatter Settings
Comment 3 Ayushman Jain CLA 2010-09-08 09:45:24 EDT
Frederic, please follow up. Thanks!
Comment 4 Mateusz Matela CLA 2018-12-28 14:59:58 EST
This problem no longer occurs after the formatter redesign.

*** This bug has been marked as a duplicate of bug 303519 ***
Comment 5 Jay Arthanareeswaran CLA 2019-01-08 09:06:22 EST
Verified for 4.11 M1 using build I20190107-2050.