Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324651

Summary:

[Tree] grid lines not correctly drawn when scrolling horizontally

Product:

[RT] RAP

Reporter:

Bogdan B. <bbarzu>

Component:

RWT

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

bbarzu, eclipse.bugzilla, ivan, tbuschto

Version:

1.4

Target Milestone:

1.4 M2

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

320597

Attachments:

Description	Flags
Code snippet producing the error	none
Screen shot of the error	none
Proposed patch	none
Code snippet producing the error - added cell editor test	none

Description Bogdan B.

2010-09-07 08:54:46 EDT

Build Identifier: RAP 1.4M1

The 1.4M1 implementation of the Tree widget does not draw the grid lines correctly (it gathers them together to the left) when the tree has many columns (let's say 20) and scrolling horizontally to the right.
I shall post in short time a code snippet and a screen shot demonstrating the problem.

I tested with Firefox 3.6.8 under Windows XP.

Maybe this is related also with Bug #313569 ?!

Reproducible: Always

Steps to Reproduce:
1. Create a tree with 20 columns
2. Scroll to the right

Comment 1 Bogdan B.

2010-09-07 08:58:26 EDT

Created attachment 178314 [details]
Code snippet producing the error

Comment 2 Bogdan B.

2010-09-07 09:01:15 EDT

Created attachment 178315 [details]
Screen shot of the error

Comment 3 Ivan Furnadjiev

2010-09-07 09:08:56 EDT

Reproducible with Controls Demo -> TreeTab too. Just change INITIAL_COLUMNS from 5 to 25 for example. Tested with FF 3.6.8 and IE8.

Comment 4 Ivan Furnadjiev

2010-09-07 09:44:44 EDT

Created attachment 178322 [details]
Proposed patch

Comment 5 Bogdan B.

2010-09-07 11:32:35 EDT

Created attachment 178333 [details]
Code snippet producing the error - added cell editor test

I added a cell editor test to the original snippet (which I marked as obsolete), just to be sure the bounds of the editor widgets are correctly calculated. Please test the patch with it!

Comment 6 Bogdan B.

2010-09-07 11:43:18 EDT

What to test in the UI showed by this snippet:
1) double click in a cell should activate a cell editor rendered by a simple Composite. Additionally, just to be sure the boundaries are correct, a PopupDialog is opened having its top left corner exactly in the same Point as the top left corner of the cell editor Composite.
2) swap 2 cells without scrolling right and double click in their cells to test the editors
3) scroll right and double click in a cell - the editor is not correctly positioned (should be with your patch)
4) also double click to test editors after scrolling right.

Comment 7 Ivan Furnadjiev

2010-09-08 02:42:17 EDT

Bogdan, I don't understand the relation between cell editor and grid lines positioning when scrolling. Maybe you mismatch this bug with bug 321489 :-)

Comment 8 Bogdan B.

2010-09-08 03:36:50 EDT

Yes, I tested both with this one snippet.
I just wanted to make sure that when you fix the grid lines by scrolling, the editors are also shown correctly. Because I really need it for M2.

Comment 9 Tim Buschtoens

2010-09-08 07:37:51 EDT

Applied patch as-is to CVS HEAD and added a test.