Bugzilla – Full Text Bug Listing
| Summary: | [patch] Config.ini & P2-based target: osgi.install.area points to .bundle_pool | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Tobias Jenkner <tobias.jenkner> | ||||
| Component: | UI | Assignee: | PDE-UI-Inbox <pde-ui-inbox> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | curtis.windatt.public | ||||
| Version: | 4.0 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | stalebug | ||||||
| Attachments: |
|
||||||
Created attachment 204145 [details]
proposed patch
The synchronizer downloads the bundles to the bundle pool, changing the location the container returns would break the LoadTargetDefinitionJob. In addition to using the bundle pool for that target's bundles, we reuse the bundle pool for other target definitions to reduce the amount of disk space and downloading. There is special processing in the LoadTargetDefinitionJob to handle this case. There might be a fix for your issue, but it will need more changes then your patch proposes. I am using this patch in my eclipse IDE for several months now and it seems to work for me. @Curtis: Can you give me a hint what you think this patch will break? (In reply to comment #3) > I am using this patch in my eclipse IDE for several months now and it seems to > work for me. > @Curtis: Can you give me a hint what you think this patch will break? Currently all target definitions share the same bundle pool locations. This is so we don't repeatedly download the same files. In addition the load target definition job does some special checks if we are getting bundles from the bundle pool location. These checks were added to deal with some incorrect enablement of bundles that no longer belong in the target (such as when you update a p2 repo location). I think there was also a problem with duplication, but that may have been fixed with Jeff's work on the synchronizer. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |
Build Identifier: When using a P2-based target the osgi.install.area property in generated config.ini files points to "[WORKSPACE]\.metadata\.plugins\org.eclipse.pde.core\.bundle_pool". Shouldn't it point to "{WORKSPACE]\.metadata\.plugins\org.eclipse.pde.core\.install_folders\[TIMESTAMP]" instead? Since my application depends on rootfiles to be in the osgi.install.area I currently have to copy them manually to ".bundle_pool" after setting the target in PDE. Reproducible: Always