Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324596

Summary: [releng][p2] consume ECF build for 3.6.1 maintenance
Product: [Eclipse Project] Equinox Reporter: Scott Lewis <slewis>
Component: p2Assignee: Pascal Rapicault <pascal>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: dj.houghton, kim.moir, markus.kell.r, pascal, remy.suen, tjwatson
Version: 3.6.1   
Target Milestone: 3.6.2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch
pascal: review+
patch pascal: iplog+

Description Scott Lewis CLA 2010-09-06 15:15:16 EDT 
In order to fix bug 316500 in the p2 3.6.1 maintenance build, a new version of ECF filetransfer (3.3.1) should be consumed.  

Here is the map file fragment for this new build (from ECF Release_3_3 stream...not HEAD/ECF 3.4 stream):

plugin@org.eclipse.ecf,3.1.0=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf_3.1.0.v20100906-1425.jar,usetimestamp=true
plugin@org.eclipse.ecf.source,3.1.0=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.source_3.1.0.v20100906-1425.jar,usetimestamp=true
fragment@org.eclipse.ecf.ssl,1.0.100=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.ssl_1.0.100.v20100906-1425.jar,usetimestamp=true
fragment@org.eclipse.ecf.ssl.source,1.0.100=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.ssl.source_1.0.100.v20100906-1425.jar,usetimestamp=true
plugin@org.eclipse.ecf.identity,3.1.0=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.identity_3.1.0.v20100906-1425.jar,usetimestamp=true
plugin@org.eclipse.ecf.identity.source,3.1.0=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.identity.source_3.1.0.v20100906-1425.jar,usetimestamp=true
plugin@org.eclipse.ecf.filetransfer,4.0.0=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.filetransfer_4.0.0.v20100906-1425.jar,usetimestamp=true
plugin@org.eclipse.ecf.filetransfer.source,4.0.0=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.filetransfer.source_4.0.0.v20100906-1425.jar,usetimestamp=true
plugin@org.eclipse.ecf.provider.filetransfer,3.1.0=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.provider.filetransfer_3.1.0.v20100906-1425.jar,usetimestamp=true
plugin@org.eclipse.ecf.provider.filetransfer.source,3.1.0=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.provider.filetransfer.source_3.1.0.v20100906-1425.jar,usetimestamp=true
fragment@org.eclipse.ecf.provider.filetransfer.ssl,1.0.0=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.provider.filetransfer.ssl_1.0.0.v20100906-1425.jar,usetimestamp=true
fragment@org.eclipse.ecf.provider.filetransfer.ssl.source,1.0.0=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.provider.filetransfer.ssl.source_1.0.0.v20100906-1425.jar,usetimestamp=true
plugin@org.eclipse.ecf.provider.filetransfer.httpclient,4.0.0=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.provider.filetransfer.httpclient_4.0.0.v20100906-1425.jar,usetimestamp=true
plugin@org.eclipse.ecf.provider.filetransfer.httpclient.source,4.0.0=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.provider.filetransfer.httpclient.source_4.0.0.v20100906-1425.jar,usetimestamp=true
fragment@org.eclipse.ecf.provider.filetransfer.httpclient.ssl,1.0.0=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.provider.filetransfer.httpclient.ssl_1.0.0.v20100906-1425.jar,usetimestamp=true
fragment@org.eclipse.ecf.provider.filetransfer.httpclient.ssl.source,1.0.0=GET,http://www.eclipse.org/external/rt/ecf/integration/platform/v2010-09-06_07-22-05/plugins/org.eclipse.ecf.provider.filetransfer.httpclient.ssl.source_1.0.0.v20100906-1425.jar,usetimestamp=true
plugin@org.apache.commons.codec,1.3.0=GET,http://download.eclipse.org/tools/orbit/downloads/drops/S20091026190351/bundles/org.apache.commons.codec_1.3.0.v20080530-1600.jar,usetimestamp=true
plugin@org.apache.commons.codec.source,1.3.0=GET,http://download.eclipse.org/tools/orbit/downloads/drops/S20091026190351/bundles/org.apache.commons.codec.source_1.3.0.v20080530-1600.jar
plugin@org.apache.commons.httpclient,3.1.0=GET,http://download.eclipse.org/tools/orbit/downloads/drops/S20091026190351/bundles/org.apache.commons.httpclient_3.1.0.v20080605-1935.jar,usetimestamp=true
plugin@org.apache.commons.httpclient.source,3.1.0=GET,http://download.eclipse.org/tools/orbit/downloads/drops/S20091026190351/bundles/org.apache.commons.httpclient.source_3.1.0.v20080605-1935.jar
plugin@org.apache.commons.logging,1.0.4=GET,http://download.eclipse.org/tools/orbit/downloads/drops/S20091026190351/bundles/org.apache.commons.logging_1.0.4.v200904062259.jar
plugin@org.apache.commons.logging.source,1.0.4=GET,http://download.eclipse.org/tools/orbit/downloads/drops/S20091026190351/bundles/org.apache.commons.logging.source_1.0.4.v200904062259.jar

Note:  

1) I do not know whether platform releng has changed the Orbit version used for httpclient, commons logging, or commons codec.  If so, it's possible that the above Orbit GETs are incorrect or in conflict with the platform's current Orbit version.

2) If desired, this contribution can/could also be used for the p2/platform 3.7 stream (see bug 219499) ...until a new version of the ECF 3.4 stream has been built.  There are two pending bugs to be addressed prior to creating this contribution/however:  bug 324248 and bug 324249.   These are being worked on, and should be fixed in 3.4 stream within a week (est).
Comment 1 Pascal Rapicault CLA 2010-09-06 15:54:07 EDT 
I have released this in the 3.6.x branch and updated the map file.
Comment 2 Pascal Rapicault CLA 2010-09-06 15:57:21 EDT 
Released in HEAD as well.
Comment 3 Scott Lewis CLA 2010-09-06 22:52:47 EDT 
Thomas:  it might be more appropriate and productive to put the review flag on bug 316500, as that's the (only) source bug for this update.  Further, you might want to have bug 316500 reviewed by some of the people that implemented the code (i.e. Matt or others).
Comment 4 Markus Keller CLA 2010-09-07 07:02:03 EDT 
(In reply to comment #2)
> Released in HEAD as well.

This causes problems in Javadoc generation: http://download.eclipse.org/eclipse/downloads/drops/N20100906-2000/compilelogs/platform.doc.isv.javadoc.txt
You have to update the versions in
/org.eclipse.platform.doc.isv/platformOptions.txt

Also, it looks wrong to me that many of the bundles got v20100906-1425 as qualifier but didn't increase the service segment.
Comment 5 Thomas Watson CLA 2010-09-07 09:41:02 EDT 
Given the questions about this bug I was a bit hasty in my +1.  I think we need to sort though the issues and defer to 3.6.2.
Comment 6 Thomas Watson CLA 2010-09-07 09:54:04 EDT 
I have asked DJ to pull this change out of the maintenance stream until we can sort through the issues.  In the future we need to get PMC approval before releasing any more fixes to 3.6.1.
Comment 7 Scott Lewis CLA 2010-09-07 10:24:48 EDT 
(In reply to comment #4)
> (In reply to comment #2)
> > Released in HEAD as well.
> 
> This causes problems in Javadoc generation:
> http://download.eclipse.org/eclipse/downloads/drops/N20100906-2000/compilelogs/platform.doc.isv.javadoc.txt
> You have to update the versions in
> /org.eclipse.platform.doc.isv/platformOptions.txt

This has nothing to do with ECF...as I don't have access to these files...it's something the platform team must deal with.

> 
> Also, it looks wrong to me that many of the bundles got v20100906-1425 as
> qualifier but didn't increase the service segment.

True...the only change was to org.eclipse.ecf.ssl bundle, so it's service segment was updated.  The others haven't changed.

>I have asked DJ to pull this change out of the maintenance stream until we can
>sort through the issues.  In the future we need to get PMC approval before
>releasing any more fixes to 3.6.1.

Thomas...my comment about this is:  if we can't get a single, close to trivial fix (i.e. bug 316500) reviewed by the people responsible for this code (IBM...see comments 4 and 5 on bug 316500), and successfully into a maintenance build in a matter of days, then it indicates to me that something is *wrong* with this process.
Comment 8 Thomas Watson CLA 2010-09-07 10:38:41 EDT 
(In reply to comment #7)
> Thomas...my comment about this is:  if we can't get a single, close to trivial
> fix (i.e. bug 316500) reviewed by the people responsible for this code
> (IBM...see comments 4 and 5 on bug 316500), and successfully into a maintenance
> build in a matter of days, then it indicates to me that something is *wrong*
> with this process.

I am sorry for the slow response on the bug, I have been trying to track Matt down for some time now.  So there is something wrong there.  But the fact is this bug does not appear to be critical and does not look like a good candidate for SR1 to me given the very late stage we are at with the RC builds for SR1.
Comment 9 DJ Houghton CLA 2011-01-10 16:25:08 EST 
Sorry for the delay in this Scott. I will release the updated bundles to 3.6.2 tomorrow and coordinate with Kim so she can update the javadoc options file.
Comment 10 DJ Houghton CLA 2011-01-11 10:08:22 EST 
Created attachment 186509 [details]
patch
Comment 11 DJ Houghton CLA 2011-01-11 10:09:10 EST 
Patch released to r36x stream.
Comment 12 Kim Moir CLA 2011-01-11 15:11:51 EST 
Created attachment 186560 [details]
patch