Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324571

Summary:

[build] Bad string comparison using !=

Product:

z_Archived

Reporter:

Torkild Resheim <torkildr>

Component:

Mylyn

Assignee:

Steffen Pingel <steffen.pingel>

Status:

RESOLVED FIXED

QA Contact:

Severity:

trivial

Priority:

Version:

unspecified

Target Milestone:

0.7

Hardware:

Macintosh

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch to fix the issue	steffen.pingel: iplog+
mylyn/context/zip	none
mylyn/context/zip	none

Description Torkild Resheim

2010-09-06 08:07:55 EDT

org.eclipse.mylyn.internal.builds.BuildImages contains a bad string comparison.

Comment 1 Torkild Resheim

2010-09-06 08:10:29 EDT

Created attachment 178262 [details]
Patch to fix the issue

Uses String.equals() instead of "".

Comment 2 Torkild Resheim

2010-09-06 08:10:31 EDT

Created attachment 178263 [details]
mylyn/context/zip

Comment 3 Steffen Pingel

2010-09-07 19:33:07 EDT

Thanks for pointing that out. I have removed the bogus check all together and made a similar change in the equivalent implementations in Bugzilla and Trac.

Comment 4 Steffen Pingel

2010-09-07 19:33:38 EDT

Created attachment 178368 [details]
mylyn/context/zip