Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324534

Summary: Wrong encoding in Xtext .source bundles
Product: [Modeling] TMF Reporter: Ralf Ebert <ralf>
Component: XtextAssignee: Jan Koehnlein <jan>
Status: CLOSED WONTFIX QA Contact:
Severity: trivial    
Priority: P3 CC: jan, sebastian.zarnekow, sven.efftinge, tmf.xtext-inbox
Version: 1.0.0   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
screenshot.png
none
0001-Bug-324534-Set-javacDefaultEncoding-to-ISO-8859-1-in.patch none

Description Ralf Ebert CLA 2010-09-05 08:14:58 EDT 
When opening Xtext sources from target platform .source bundles, umlauts in javadocs appear as unknown character. For example in ResourceValidatorImpl.

This is annoying, because this character is larger than normal characters and increases the line height in the editor.
It might also indicate that the classes are compiled with the wrong encoding; because usually Eclipse handles .source encodings correctly.

It might be worth trying to add the encoding to the build.properties as suggested in the attached patch (untested, I don't have a build running here). If I remember correctly, PDE build needs an extra invitation and doesn't use the project encoding.
Comment 1 Ralf Ebert CLA 2010-09-05 08:16:18 EDT 
Created attachment 178225 [details]
screenshot.png
Comment 2 Ralf Ebert CLA 2010-09-05 08:17:51 EDT 
Created attachment 178226 [details]
0001-Bug-324534-Set-javacDefaultEncoding-to-ISO-8859-1-in.patch
Comment 3 Sebastian Zarnekow CLA 2011-01-15 15:16:38 EST 
We have to set the encoding in other build.properties files, too.
Comment 4 Jan Koehnlein CLA 2011-01-28 05:44:08 EST 
I tried the javacDefaultEncoding option but it doensn't change anything.
It seems that the standard "jars don't define encoding" problem also applies to source bundles. Unscheduling this bug as there is no simple solution.
Comment 5 Sven Efftinge CLA 2011-03-26 15:49:03 EDT 
setting to won't fix, due to Jan's comment. Please reopen with a solution to that problem.