Bugzilla – Full Text Bug Listing
| Summary: | SystemEditableRemoteFile throws NPE when used in headless mode | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] Target Management | Reporter: | Ankit Pasricha <ankitp> | ||||||
| Component: | RSE | Assignee: | David McKnight <dmcknigh> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Martin Oberhuber <mober.at+eclipse> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | dmcknigh, kjdoyle, samuelwu | ||||||
| Version: | 3.2.1 | Flags: | mober.at+eclipse:
pmc_approved+
kjdoyle: review+ |
||||||
| Target Milestone: | 3.2.2 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 178349 [details]
patch to check for null editor registry
Ankit, does this patch help your situation or is there more to it?
Hi Dave, I think you attached the wrong patch....this patch has way too many changes and does not seem to be in the correct area of the code :) Created attachment 178360 [details]
update with correct patch
(In reply to comment #2) > Hi Dave, > > I think you attached the wrong patch....this patch has way too many changes and > does not seem to be in the correct area of the code :) Sorry, I've put in the correct patch this time. Hi Dave, The patch looks good. Martin and Kevin could you please review this? +1 I can't see an issue with this, please commit. Thanks for the review, Martin. I've committed the change to cvs. Looks good to me as well. Released, please test with the next M-Build (should be M20100909-1340). Please set the bug VERIFIED when OK. Verified that this has been released to 3.3m3 as well. |
I have some code that constructs a SystemEditableRemoteFile from an IRemoteFile and is run in headless mode. I get the following exception when this code is run; java.lang.NullPointerException at org.eclipse.rse.files.ui.resources.SystemEditableRemoteFile.<init>(Sy stemEditableRemoteFile.java:271) at org.eclipse.rse.internal.files.ui.view.SystemViewRemoteFileAdapter.ge tEditableRemoteObject(SystemViewRemoteFileAdapter.java:3454) The problem is that the editor registry is null in headless mode but the code in the SystemEditableRemoteFile does not check for this. Can you please add a check to make sure that the editor registry is not null before setting the editorDescriptor.