Bugzilla – Full Text Bug Listing
| Summary: | Generic History View: "description" property is never rendered | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Mathias Kinzler <mathias.kinzler> |
| Component: | Team | Assignee: | Platform Team Inbox <platform-team-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | remy.suen |
| Version: | 3.6 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | stalebug | ||
Have you looked at other references to org.eclipse.team.ui.history.IHistoryPage.P_DESCRIPTION? I didn't run the code but org.eclipse.team.ui.history.HistoryPageCompareEditorInput.handlePropertyChange(PropertyChangeEvent) looks like it does the job. Could you verify that? (In reply to comment #1) > Have you looked at other references to > org.eclipse.team.ui.history.IHistoryPage.P_DESCRIPTION? I didn't run the code > but > org.eclipse.team.ui.history.HistoryPageCompareEditorInput.handlePropertyChange(PropertyChangeEvent) > looks like it does the job. Could you verify that? I saw this reference, but the handler is not called at all; the only handler that's being called is the one in GenericHistoryView (the code which I pasted into the description). This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |
The Javadoc of IHistoryPage says: /** * Returns a one line description of the object whose history is * being displayed. For example, for files, this may be the * workspace path of the file. The description may be displayed to * the user as tooltip text or by some other means. * @return a one line description of the object whose history is * being displayed or <code>null</code> * @since 3.2 */ public String getDescription(); and there is an API to notify the GenericHistoryView about changes of that property. But in the propertyChange method of the GenericHistoryView, which handles this event, the codes does nothing: public void propertyChange(PropertyChangeEvent event) { if (event.getSource() == currentPageContainer.getPage()) { if (event.getProperty().equals(IHistoryPage.P_NAME)) { ... (removed for shortness) } else if (event.getProperty().equals(IHistoryPage.P_DESCRIPTION)) { // We don't show the description } } } This looks like an inconsistency to me... Or is there any way to get this description rendered?