Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324385

Summary: [search] Double-click in Search results pages should always toggle expansion
Product: [Eclipse Project] Platform Reporter: Markus Keller <markus.kell.r>
Component: SearchAssignee: Markus Keller <markus.kell.r>
Status: RESOLVED WONTFIX QA Contact:
Severity: minor    
Priority: P3 CC: daniel_megert, deepakazad
Version: 3.7   
Target Milestone: 3.7 M2   
Hardware: PC   
OS: Mac OS X   
Whiteboard:
Attachments:
Description Flags
Fix
none
Complete undo none

Description Markus Keller CLA 2010-09-03 05:17:14 EDT
Created attachment 178126 [details]
Fix

HEAD

Double-click in Search results pages should always toggle expansion.
Comment 1 Markus Keller CLA 2010-09-03 05:17:49 EDT
Fixed in HEAD.
Comment 2 Deepak Azad CLA 2010-10-12 05:52:36 EDT
This new behavior is a bit confusing as the double click now does 2 things.
- Everywhere else (package explorer, call hierarchy view) double click just opens the editor, hence as a user I am used to this behavior
- Secondly, once a search result is expanded and you double click to open the editor, the expansion state toggles => as a user you may or may not want this.
Comment 3 Markus Keller CLA 2010-10-12 07:00:29 EDT
Created attachment 180658 [details]
Complete undo

The TOC in the Eclipse help also does both on double-click (but it already opens the page on single-click). But I agree that in the Search view, the collapsing is confusing now, and since having this feature only for expansion is also confusing, I'll revert the changes.

The attached fix was not complete. Here's the complete patch to undo all changes.
Comment 4 Markus Keller CLA 2010-10-12 07:01:06 EDT
Reverted in HEAD.