Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324349

Summary:

custom closed statuses are never used

Product:

z_Archived

Reporter:

David Shepherd <david.shepherd>

Component:

Mylyn

Assignee:

Frank Becker <eclipse>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

charley.wang, eclipse, robert.elves

Version:

unspecified

Target Milestone:

3.5

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

259291

Attachments:

Description	Flags
Possible solution for statuses issue.	none
mylyn/context/zip	none
mylyn/context/zip	none
commited patch	none
mylyn/context/zip	none

Description David Shepherd

2010-09-02 16:07:46 EDT

The Bugzilla Repository Settings Page allows you to specify a "Workflow Description File" under the additional settings section.  This file is supposed to let you designate custom statuses as closed statuses (thus showing as complete in your Task List) according to: 

http://wiki.eclipse.org/Mylyn_Bugzilla_Connector#Custom_Transitions
"ClosedCustomStatus is a list of custom statuses which leave the bug in a closed state. Defaults to an empty list if unspecified."

However, the closed statuses specified by this file are never read.

Comment 1 David Shepherd

2010-09-02 16:21:02 EDT

Created attachment 178098 [details]
Possible solution for statuses issue.

Comment 2 David Shepherd

2010-09-02 16:21:04 EDT

Created attachment 178099 [details]
mylyn/context/zip

Comment 3 David Shepherd

2010-09-02 16:23:43 EDT

To solve this problem you can make the repository configuration return the closed statuses specified in the file, via the CustomTransitionManager, if it exists.  This is the approach that the patch takes.

Comment 4 Steffen Pingel

2010-09-02 16:58:38 EDT

Also need to verify whether it is required to manually refresh the configuration after specifying a file. This should not be necessary.

Comment 5 David Shepherd

2010-09-02 17:10:22 EDT

(In reply to comment #4)
> Also need to verify whether it is required to manually refresh the configuration
> after specifying a file. This should not be necessary.
Note: commented on parent task re this issue as it could effect all related issues.  I was able to verify that it does require a manual refresh of the configuration before the RepositoryConfiguration is updated.

Comment 6 Frank Becker

2010-09-05 03:30:27 EDT

David,

I think after apply patch of bug#324525 we can close this bug to.

Can you please verify.

Comment 7 Frank Becker

2010-09-05 03:30:29 EDT

Created attachment 178224 [details]
mylyn/context/zip

Comment 8 David Shepherd

2010-09-07 13:10:16 EDT

(In reply to comment #6)
> David,
> 
> I think after apply patch of bug#324525 we can close this bug to.
> 
> Can you please verify.

Frank,
This definitely fixes the problem related to refreshing the repository after adding a new status file, great!  However, the closedStatuses in the RepositoryConfiguration are still never used and thus this bug should remain open.  To reproduce the problem I'm seeing.
# Connect to a standard Bugzilla instance
# Create a file named status.txt with the following contents:


bq. CustomStatusNames=true
DuplicateStatus=DUPLICATE
StartStatus=CLOSED
ClosedCustomStatus=ASSIGNED
ClosedCustomStatus=NEW
<transitions>
name :ASSIGNED:, can_change_to :NEW,POST,CLOSED:
name :NEW:, can_change_to :POST,ASSIGNED,CLOSED:

# Open the Repository Settings of the Bugzilla and point it at the status file
# Note that bugs with a status of NEW should now appear with a strikethrough, as they are specified as complete by the status file
# Refresh a bug with a status of NEW, it still does not have a strikethrough

This is because the closedStatus field in the CustomTransitionManager is never used by the RepositoryConfiguration.  I think that the RC should just return the validTransitions' closed statuses if it exists.

Comment 9 Frank Becker

2010-12-05 15:03:20 EST

Created attachment 184561 [details]
commited patch

Comment 10 Frank Becker

2010-12-05 15:03:23 EST

Created attachment 184562 [details]
mylyn/context/zip

Comment 11 Frank Becker

2010-12-05 15:06:51 EST

(In reply to comment #8)
...
> This is because the closedStatus field in the CustomTransitionManager is never
> used by the RepositoryConfiguration.  I think that the RC should just return the
> validTransitions' closed statuses if it exists.

Now the validTransitions' closed statuses are used  when not present we use the RepositoryConfiguration values.