Bugzilla – Full Text Bug Listing
| Summary: | [Probekit] [zOS] Workaround zOS XML character handling to enable ProbekitAgent | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Mike Reid <mikereid> | ||||||
| Component: | TPTP | Assignee: | Mike Reid <mikereid> | ||||||
| Status: | CLOSED FIXED | QA Contact: | Kathy Chan <kathy> | ||||||
| Severity: | major | ||||||||
| Priority: | P2 | CC: | ernest, jgwest, pklicnik | ||||||
| Version: | unspecified | Flags: | kathy:
pmc_approved?
(oec) ernest: pmc_approved+ kathy: pmc_approved? (kathy) jgwest: pmc_approved+ kathy: pmc_approved? (jerome.bozier) jgwest: review+ |
||||||
| Target Milestone: | --- | ||||||||
| Hardware: | Other | ||||||||
| OS: | other | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Mike Reid
Created attachment 178077 [details]
Patch
Attaching a patch which filters out the problematic characters.
Additionally, the call to ascii_stricmp in BCIEngProbeInterface.cpp assumes input in EBCDIC encoding when in fact ProbekitAgent code path passes strings with ASCII encoding. Patch includes minor fix for this as well.
Created attachment 178179 [details]
Updated patch
Updated patch to fix another problem discovered in BCIEngProbe.cpp which assumed compilation in EBCDIC whereas ASCII option is used.
Hi Jonathan, Could you please review the attached patch? Thanks, /mike. Patch is good. Requesting we bring this for for PMC approval: 1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? Executing probes on zOS will fail without this fix. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? No. 3. Is this a regression or API breakage? Explain. No regression, this functionality is only recently ported to zOS. 4. Does this require new API? No. 5. Who performed the code review? Jonathan West 6. Is there a test case attached to the bugzilla record? No. 7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix? Modify character handling on zOS. All changes limited to zOS codepath (i.e. builds on other platforms are unaffected). Furthermore the zOS changes only affect the ProbekitAgent code path, all other profiling modes are unaffected. Low risk due to low scope. 8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? n/a. Requesting PMC approval for TPTP 4.7.1. Patch checked into HEAD with PMR approval. This defect had been resolved as FIXED for more than 1 month. Please verify with the latest TPTP 4.7.2 driver. If this defect is still left unverified by February 25, we'll close it on the originator's behalf. TPTP 4.7.2 driver can be downloaded from: http://www.eclipse.org/tptp/home/downloads/?ver=4.7.2 Closing. |