Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324313

Summary: Update feature and plug-in versions
Product: z_Archived Reporter: Joel Cayne <jcayne>
Component: TPTPAssignee: Kathy Chan <kathy>
Status: CLOSED FIXED QA Contact: Kathy Chan <kathy>
Severity: major    
Priority: P2 CC: ernest, jcayne, mikereid, paulslau
Version: unspecifiedFlags: kathy: pmc_approved? (oec)
ernest: pmc_approved+
kathy: pmc_approved? (kathy)
jgwest: pmc_approved+
kathy: pmc_approved? (jerome.bozier)
jcayne: review+
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch to Manifest.MFs
none
Doc User Patch
none
Patch for feature version number
none
Patch to org.eclipse.hyades.test.ui
none
Patch for platform.models
none
Patch (Test Project plug-ins/features for 4.7.0.x development). none

Description Joel Cayne CLA 2010-09-02 10:35:43 EDT
Please update the feature and plug-in versions based on the latest build report.
Comment 1 Kathy Chan CLA 2010-09-07 11:40:25 EDT
Jonathan, 

These are mainly plugins and features you've updated during TPTP 4.7.1.  Could you please properly increase the vesrion number of the plugins and features based on the version update convention used in Eclipse?  A few of the probekit plugins were probably updated by Mike, please check with him.  Thanks!
Comment 2 Jonathan West CLA 2010-09-07 14:47:52 EDT
Created attachment 178350 [details]
Patch to Manifest.MFs
Comment 3 Jonathan West CLA 2010-09-07 14:48:15 EDT
Hi Joel, can you review the plugin changes?
Comment 4 Jonathan West CLA 2010-09-08 14:17:50 EDT
Created attachment 178430 [details]
Doc User Patch

Joel, can you review this one as well?
Comment 5 Joel Cayne CLA 2010-09-08 14:23:55 EDT
Patches for updating the Plug-in Manifests (including for the doc user plug-ins) look good.
Comment 6 Kathy Chan CLA 2010-09-09 13:09:24 EDT
Created attachment 178533 [details]
Patch for feature version number

Patch for feature version number.
Comment 7 Kathy Chan CLA 2010-09-09 13:10:04 EDT
Jonathan, please review the feature version number patch.
Comment 8 Jonathan West CLA 2010-09-09 13:30:46 EDT
Patch is good.
Comment 9 Jonathan West CLA 2010-09-09 13:43:34 EDT
I would like to ask for PMC approval to include the fix of this bug in TPTP v4.7.1.

   1.   Explain why you believe this is a stop-ship defect. How does the defect
manifest itself, and how will users of TPTP / consuming products be affected if
the defect is not fixed?
Plugins and features versions are required to be updated before final release.

   2. Is there a work-around? If so, why do you believe the work-around is
insufficient?
No.

   3. Is this a regression or API breakage? Explain.
No.

   4. Does this require new API?
No.

   5. Who performed the code review?
Joel for my changes, myself for Kathy's changes

   6. Is there a test case attached to the bugzilla record?
N/A

   7. What is the nature of the fix? What is the scope of the fix? What is the
risk associated with this fix?
Fix to the plugin manifest, and feature.xml files only. Low risk.

   8. Is this fix related to any standards that TPTP adheres to? If so, who has
validated that the fix continues to adhere to the standard?
        n/a
Comment 10 Kathy Chan CLA 2010-09-09 13:45:31 EDT
Requesting PMC approval for TPTP 4.7.1.
Comment 11 Kathy Chan CLA 2010-09-09 13:50:39 EDT
Feature version patch checked into HEAD.
Comment 12 Jonathan West CLA 2010-09-09 14:25:42 EDT
Created attachment 178542 [details]
Patch to org.eclipse.hyades.test.ui

I wasn't able to check this into test project, posting this for Kathy to checkin.
(This patch is a one-plugin subset of the original patch)
Comment 13 Kathy Chan CLA 2010-09-09 14:36:58 EDT
Patch to org.eclipse.hyades.test.ui checked in.
Comment 14 Jonathan West CLA 2010-09-09 14:39:07 EDT
Remaining patches checked into HEAD w/ PMC approval.
Comment 15 Kathy Chan CLA 2010-09-10 10:26:33 EDT
Created attachment 178614 [details]
Patch for platform.models

One more version update necessary for platform.models (changed after 09/07).
Comment 16 Kathy Chan CLA 2010-09-10 10:31:27 EDT
Re-opening to make a couple more necessary version number change based on the latest build.

Please note that the feature containing platform.models had already been incremented, so only platform.models need version number update, not the feature containing it.
Comment 17 Kathy Chan CLA 2010-09-10 10:42:38 EDT
Patch for platform.models checked into HEAD (Jonathan had reviewed it).

Over to you, Paul.
Comment 18 Paul Slauenwhite CLA 2010-09-10 11:56:46 EDT
Created attachment 178627 [details]
Patch (Test Project plug-ins/features for 4.7.0.x development).
Comment 19 Paul Slauenwhite CLA 2010-09-10 11:57:14 EDT
Kathy, could you please review?
Comment 20 Paul Slauenwhite CLA 2010-09-10 13:40:08 EDT
(In reply to comment #19)
> Kathy, could you please review?

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=324996.
Comment 21 Kathy Chan CLA 2010-09-10 14:37:16 EDT
Resolving since Paul is making the version number change for the test project plugin as part of bug 324996.
Comment 22 Joel Cayne CLA 2010-10-04 08:47:54 EDT
Verified on the TPTP-4.7.1-201009131917 build report.