Bug 324312

Comment 1 Kathy Chan 2010-09-07 11:34:40 EDT

Here's the files containing the wrong copyright years based on the 09/06 build report:

1 plugins/org.eclipse.tptp.platform.agentcontroller/src-native-new/src/transport/transportSupport/TransportOSCalls_solaris.c
2 plugins/org.eclipse.tptp.platform.jvmti.runtime/src-native/src/Martini/Infrastructure/OSA/Aix/Common/LibraryLoader.cpp
3 plugins/org.eclipse.tptp.platform.jvmti.runtime/src-native/src/Martini/Infrastructure/OSA/zOS/Common/LibraryLoader.cpp
4 plugins/org.eclipse.tptp.platform.jvmti.runtime/src-native/src/Martini/Infrastructure/OSA/zOS/Common/OSAL.cpp
5 plugins/org.eclipse.hyades.trace.ui/src/org/eclipse/hyades/trace/ui/internal/launcher/ProfileTab.java
6 plugins/org.eclipse.tptp.platform.jvmti.runtime/src-native/include/Martini/OSA.h
7 plugins/org.eclipse.tptp.platform.jvmti.runtime/src-native/src/Martini/Include/LibraryLoader.h
8 plugins/org.eclipse.tptp.trace.arm.doc.user/topics/arm_gen_servers.htm
9 plugins/org.eclipse.hyades.logging.core/src/org/eclipse/hyades/logging/core/properties/plugin.properties

Mike, these are files you and Jonathan had updated during TPTP 4.7.1 but had not updated copyright years.  Could you please put together a patch to handle updating the copyright years for the above changes?  

You can ignore plugins/org.eclipse.hyades.logging.core/src/org/eclipse/hyades/logging/core/properties/plugin.properties
for now since it looks like it's the result of some glitch of the copyright checking tools (the file does not exist).  Sean was looking into it before he left.  Joel, do you know anything about this?

Comment 2 Mike Reid 2010-09-07 12:30:43 EDT

Created attachment 178339 [details]
Patch

Attached patch to fix copyrights in files mentioned.

Comment 3 Mike Reid 2010-09-07 14:49:52 EDT

Created attachment 178351 [details]
Updated patch

Attached new patch to include org.eclipse.hyades.loaders.GenerateConstants copyright notice fix.

Comment 4 Mike Reid 2010-09-07 14:51:10 EDT

Requesting to bring this forward for PMC approval:

   1.   Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed?
   
   Incorrect copyright information. 
   
   2. Is there a work-around? If so, why do you believe the work-around is insufficient?
   
   n/a
   
   3. Is this a regression or API breakage? Explain.
   
   n/a
   
   4. Does this require new API?
   
   No.
   
   5. Who performed the code review?
   
   Not requested. No executable code was changed, just copyright notices.
   
   6. Is there a test case attached to the bugzilla record?
   
   n/a
   
   7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix?
   
   Fix to copyright notices to accurately reflect date of updates.
   
   8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard?
   
   n/a.

Comment 5 Kathy Chan 2010-09-07 16:14:37 EDT

I've reviewed the patch.

Requesting PMC approval for TPTP 4.7.1.

Comment 6 Mike Reid 2010-09-08 11:21:30 EDT

Patch checked into HEAD.

Comment 7 Kathy Chan 2010-09-10 10:44:00 EDT

The latest copyright report (based on 09092249) still has this file flaged as not having the correct copyright:

plugins/org.eclipse.tptp.platform.agentcontroller/src-native-new/src/transport/transportSupport/TransportOSCalls_solaris.c

I checked the history and found that Mike did make the change to 2010 copyright year on 09/08 but it was on version 1.2.4.1, not the one from HEAD.  HEAD is still picking up version 1.3 which has 2009.

Comment 8 Mike Reid 2010-09-10 10:57:39 EDT

Checked in the change to TransportOSCalls_solaris.c into HEAD this time.

Comment 9 Joel Cayne 2010-10-04 08:48:58 EDT

Verified on the TPTP-4.7.1-201009131917 build report.