Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324311

Summary: Don't generate product root feature if there will be no .eclipseproduct file
Product: [Eclipse Project] PDE Reporter: Kim Moir <kim.moir>
Component: BuildAssignee: pde-build-inbox <pde-build-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: aniefer, john.arthorne
Version: 3.7   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
releng patch none

Description Kim Moir CLA 2010-09-02 10:25:40 EDT 
I'm trying to build with 3.7M1 bundles and am getting the following error when running the director

Installing org.eclipse.platform.ide 3.7.0.N20100901-1150.
Installation failed.
!ENTRY org.eclipse.equinox.p2.director 4 1
!MESSAGE Cannot complete the install because one or more required items could not be found.
!SUBENTRY org.eclipse.equinox.p2.director 4 0
!MESSAGE Software being installed: Eclipse Platform 3.7.0.N20100901-1150 (org.eclipse.platform.ide 3.7.0.N20100901-1150)
!SUBENTRY org.eclipse.equinox.p2.director 4 0
!MESSAGE Missing requirement: Eclipse Product Configuration 1.0.0.N20100901-1150 (org.eclipse.rcp.configuration.feature.group 1.0.0.N20100901-1150) requires 'org.eclipse.rcp.configuration.root.feature.feature.group [1.0.0.N20100901-1150]' but it could not be found
!SUBENTRY org.eclipse.equinox.p2.director 4 1
!MESSAGE Cannot satisfy dependency:

The rcp.configuration is a feature that we generate to include the executables etc. in the metadata.  Its id is org.eclipse.rcp.configuration.  

Looking at the content.xml, there is a requirement for this
<required namespace='org.eclipse.equinox.p2.iu' name='org.eclipse.rcp.configuration.root.feature.feature.group' 
range='[1.0.0.N20100901-1150,1.0.0.N20100901-1150]'/>

Why is there an extra "feature". in the namespace?  Older builds built with previous bundles list the name as org.eclipse.rcp.configuration.root.feature.group?

Andrew, the test build is N201009011150 if you are interested in looking at it.
Comment 1 Andrew Niefer CLA 2010-09-02 14:02:25 EDT 
Created attachment 178073 [details]
releng patch

Kim, you should use this patch.
This is somewhat caused by the non-standard way we generate the p2.inf for the org.eclipse.rcp.configuration feature based on a .product file.

When generating features based on .product files, an extra nested feature gets generated named *.root.feature, this feature is used for any extra plugins/features/root files that are supposed to be added to the product.  This is also used for generation of the .eclipseproduct file.

If this had been a standard product build, the error would not have occured but we would have ended up with a binary artifact that didn't actually contain any files because the .eclipseproduct file wasn't actually generated because our rcp.config product file does not have a name or id.

This mostly comes from bug 274517

So there is a problem in the releng setup, it needs to turn this nested feature off because it is just extracting generated files and not actually running that product build.

There is also a problem in PDE/Build because we shouldn't generate this feature if we don't actualy end up putting anything in it.
Comment 2 Kim Moir CLA 2010-09-02 14:26:54 EDT 
Thanks Andrew, I'll try another test build with your patch.
Comment 3 Kim Moir CLA 2010-09-02 17:19:40 EDT 
Test build was successful, can now build with 3.7M1 bundles.
Comment 4 John Arthorne CLA 2013-02-05 16:00:48 EST 
I also back-ported this patch to the 3.6 builder to support maintenance builds:

http://git.eclipse.org/c/platform/eclipse.platform.releng.eclipsebuilder.git/commit/?h=R3_6_maintenance&id=a6aea3e3c1c12989feec5eeefd82d878b1305dc4
Comment 5 Lars Vogel CLA 2018-12-03 09:07:50 EST 
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.