Bugzilla – Full Text Bug Listing
| Summary: | pde.junit.runtime.addon feature mal-formed | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Jeff McAffer <jeffmcaffer> | ||||
| Component: | UI | Assignee: | PDE-UI-Inbox <pde-ui-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | hmalphettes, kim.moir | ||||
| Version: | 3.6 | ||||||
| Target Milestone: | 3.7 M2 | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
I put this sin the PDE bucket but in practice, this feature was contributed by the Jetty team and it may be best for them to do the fix and contribute it to Helios SR1 as, I believe, the feature is not yet in PDE's releng build setup. That is being done for Indigo. Thanks Jeff! Sorry about this. Fixed with commit 2232 for Helios-SR1 Also, the junit line should specify 4.8.1.qualifier since we have multiple junit bundles in our build. Kim, currently the line in the jetty repo is: <plugin id="org.junit" download-size="0" install-size="0" version="4.8.1" unpack="true"/> In the jetty build the qualifier is something like v20100831 It is not going to match the qualifier of the org.junit bundle in the eclipse-platform repository. I am assuming you are suggesting this improvement for the features that lives in the indigo repository of the eclipse-platform? The "qualifier" is replaced by the actual qualifier of the org.junit 4.8.1 bundle included in the platform build at build time :-) These new pde.junit* features are now included in our 3.7 build so we are consuming the same bundles that are in our build. (In reply to comment #5) > The "qualifier" is replaced by the actual qualifier of the org.junit 4.8.1 > bundle included in the platform build at build time :-) > > These new pde.junit* features are now included in our 3.7 build so we are > consuming the same bundles that are in our build. Makes sense! So I am leaving it as is in the helios build of jetty. I think this bug can be closed. These features are now enabled in the build. See bug 323062 for details. |
Created attachment 177957 [details] Fixed feature file in the Helios repo there is a feature call org.eclipse.pde.junit.runtime.addon in the Target Platform category. This is something that came from the Jetty guys but is being adopted by the platform team. In any event, the feature as it is in the repo is malformed. The <requires> element needs to have <import> sub-elements rather than directly identifying the feature/plugin to require. A "fixed" version of the feature is attached to this bug. Ideally this would be put into the maintenance release as without this fix it is hard/impossible for people to use the feature as it does not parse. The change/fix is very safe, especially since it clearly did not work before so people could not be using it :-/