Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324151

Summary:

[New Assembly directive] Check box option to assemble projects into WEB-INF/lib is confusing

Product:

[WebTools] WTP Java EE Tools

Reporter:

Ram Venkataswamy <ram.venkataswamy>

Component:

jst.j2ee

Assignee:

Konstantin Komissarchik <konstantin>

Status:

RESOLVED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

enhancement

Priority:

CC:

cbridgha, ccc, jsholl, konstantin, stryker

Version:

3.2

Keywords:

plan

Target Milestone:

3.3 M3

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch v1	none

Description Ram Venkataswamy

2010-08-31 18:42:10 EDT

Build Identifier: M20100818-0800

Check box option to assemble projects into WEB-INF/lib on New Assembly directive wizard is bit confusing

Reproducible: Always

Steps to Reproduce:
- create a web project and add it to EAR

- Create a utility project (not part of EAR)

- On web project | properties | Deployment assembly, we can add utility project (while adding a project we have an option to check if it should be part of WEB-IN/lib folder)

- Add the utility project (not part of WEB-INF/lib, un-check the option)

- Export the EAR and deploy to a RT

- The jsp fails to resolve the reference from utility project

FYI: In the WAR, the utility jar is dumped at the root.
 
What is the use of not wanting the project/jar as part of WEB-INF/lib (and get dumped at the root of war file)?

Comment 1 Konstantin Komissarchik

2010-08-31 19:16:16 EDT

The real question here is whether the add project reference wizard needs to have this checkbox at all. All it does it toggle between "WEB-INF/lib" and "/" as the initial deploy path. None of the other add wizards offer ability to influence deploy path right from the wizard. I propose that for consistency sake, this option be removed from the add project reference wizard. No functionality would be lost. The rare user that does want to map the jar somewhere other than WEB-INF/lib can make that selection in the deployment assembly page once the wizard completes.

Comment 2 Konstantin Komissarchik

2010-08-31 19:17:24 EDT

Let's consider this for Indigo.

Comment 3 Chuck Bridgham

2010-10-20 20:34:57 EDT

This is a good idea - less complication... removing an option nobody would ever want. - can you add a patch?

Comment 4 Rob Stryker

2010-10-21 04:39:35 EDT

I also think it's a good suggestion. The deployment assembly page does all that's needed. The checkbox adds nothing.

Comment 5 Konstantin Komissarchik

2010-10-21 14:10:04 EDT

Created attachment 181428 [details]
Patch v1

Ignore the changes to java compiler settings in the project. I am using 3.7 M2 as my dev eclipse and practically every java ee tools project has optional java validation things flagged as errors. I will not be releasing these setting changes as part of this fix. It will need to be looked at separately.

Comment 6 Jason Sholl

2010-10-22 10:52:16 EDT

I agree; the less complicated the better.  Do you think this is also worth pulling back to WTP 3.2.3?

Comment 7 Konstantin Komissarchik

2010-10-22 12:03:44 EDT

Released the patch to 3.3 M3 stream.

> Do you think this is also worth pulling back to WTP 3.2.3?

I am ambivalent on that. It's a fairly small improvement and being a UI change would require PMC approval... But it is perfectly safe and it is an improvement in usability. Let me know how you guys would like to go on this. I will back-port the patch (open a separate bug) if necessary.

Comment 8 Jason Sholl

2010-10-26 17:07:02 EDT

Yes, could you please backport this for 3.2.3.  Thanks.