Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324143

Summary:

[Form Editor] Problems in Tigerstripe editors

Product:

[Technology] Tigerstripe

Reporter:

Navid Mehregani <nmehrega>

Component:

Assignee:

Navid Mehregani <nmehrega>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

valentin, yuri

Version:

unspecified

Target Milestone:

0.5M0

Hardware:

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
Project Descriptor	none
Dialog problem	none
Up and down buttons problem fixes	none
Stereotype auto scroll problem(Comment #6) patch	none

Description Navid Mehregani

2010-08-31 17:54:05 EDT

Build Identifier:

This defect is a general placeholder of problems in Tigerstripe editors. There is a lot of small problems lurking around. Rather than creating a separate defect for each one, I'd like to keep everything under one defect and address all the issues here.

Plug-in Descriptor Editor:
- Select Properties page > add > Add a table property, select it, notice the button for Column Names don't line up (that's the first problem). Create two columns, called 'Name' and 'Description'. Make sure 'Description' is the second column. Select Description such that it's editable, click on Up. Notice that the name of both columns change to 'Description'!! (this is the second and more serious problem).

- Under Rules page, create a new Artifact Rule by clicking on Add under 'Artifact Rule' section. The newly created rule should be selected and all of its corresponding properties are displayed to its right. Now add a new Global Rule, by clicking on Add under 'Global Rules'. The newly created rule is selected and the artifact rule is deselected. Now try selecting the Artifact Rule to display its properties. Notice that selecting it will not display its properties. You have to deselect it and select it again in order for its properties to be displayed.
User should actually be able to display properties of both an Artifact Rule and a Global Rule. Since these are displayed under different sections (in different lists), you should be able to select elements under both of these lists and have their properties displayed at the same time.

- Select an artifact rule > in the artifact type combo box, the list is NOT sorted. Makes it difficult to find what you're looking for. Specially since this is a combo box.

Session Facade Artifact Editor:
- Add a new method > Add an argument for the method > select the argument and click on Edit > for the dialog that pops up:
o The 'argument type' text field should not be editable
o 'Browse' button for argument type should read 'Select'. 'Browse' is typically associated with selecting something in the file system.

- For the session facade editor, the source page should be the last page that's displayed.

Model Project Descriptor:
- Max/min version text boxes are not displayed properly in the project descriptor editor (see attached file). Note that this may be a SWT-Mac issue.

Reproducible: Always

Comment 1 Navid Mehregani

2010-08-31 17:57:04 EDT

Created attachment 177898 [details]
Project Descriptor

Text boxes for max/min versions are cut off

Comment 2 Navid Mehregani

2010-09-01 15:37:45 EDT

All artifact editors:

- When you add a stereotype and save the file, the stereotype text box shortens.  When you delete all stereotypes and save the file, it turns back to normal!

Comment 3 Yuri Strot

2010-09-03 05:43:00 EDT

Hi Navid,

I've just checked in fixes for all problems except two issues:

1. Can't reproduce problem with "Up" button for table properties. Is it problem already fixed?

2. Can't reproduce max/min text issue on Windows. So we'll check and fix it a bit later on Mac.

Comment 4 Navid Mehregani

2010-09-03 12:37:01 EDT

(In reply to comment #3)

Hi Yuri,

> 1. Can't reproduce problem with "Up" button for table properties. Is it problem
> already fixed?

I just confirmed that the problem still exists.  When you select a column, make sure it's in edit mode then click on Up.  If you still can't reproduce this, I can run a webEx to show you in 5 mins.

> 2. Can't reproduce max/min text issue on Windows. So we'll check and fix it a
> bit later on Mac.

As mentioned before, this may be an SWT/Mac related issue.  If it doesn't have an easy fix, I wouldn't put too much emphasis on it.

Thanks!

Comment 5 Navid Mehregani

2010-09-17 17:14:40 EDT

Created attachment 179153 [details]
Dialog problem

Here's another problem:

Create an Entity artifact
Under stereotypes, click on Add
Select 'AlternateKey1' and click on OK
Select the stereotype and click on Edit

You get the attached dialog, which doesn't have the 'Add' 'Remove' buttons aligned.  Also clicking on 'Add' will add an *empty* field to the table.  This gives the impression that nothing was added.

Comment 6 Navid Mehregani

2010-09-17 17:17:56 EDT

Another problem:

- Under Entity editor, add a new method
- Select the method
- Click on Add for the 'Stereotype' table
- Select a stereotype and click on OK.  Notice that the editor auto scrolls to the top.  Editor should keep the scrolling position the same.

Comment 7 Valentin Yerastov

2010-09-27 04:48:44 EDT

The following items fixed
- max/min text issue
- Comment 5(Stereotype dialog problem)


The following items not reproducable on our side:
- Can't reproduce problem with "Up" button for table properties.
- comment 6

Comment 8 Navid Mehregani

2010-09-27 10:22:53 EDT

(In reply to comment #7)
> The following items not reproducable on our side:
> - Can't reproduce problem with "Up" button for table properties.
> - comment 6

Valentin,
I'll try and create a video to better demonstrate the above issues.

Comment 9 Valentin Yerastov

2010-10-05 12:15:06 EDT

I reproduced problem with "Up" button for table properties on the Mac. I'll fix it.
Problem described in comment 6 still does not reproduce for me on Mac.

Comment 10 Valentin Yerastov

2010-10-06 05:47:59 EDT

Created attachment 180304 [details]
Up and down buttons problem fixes

Comment 11 Valentin Yerastov

2010-10-06 05:51:30 EDT

Created attachment 180305 [details]
Stereotype auto scroll problem(Comment #6) patch

Comment 12 Valentin Yerastov

2010-10-06 06:04:23 EDT

We unable to reproduce the stereotype problem, but we found a generic unnecessary autoscroll behavior in tigerstripe editors. We fixed this problem. Please, check that this should fix the stereotype problem.

Comment 13 Yuri Strot

2010-10-06 08:36:10 EDT

I've applied these patches. Navid could you please validate it?

Comment 14 Navid Mehregani

2010-10-07 16:08:17 EDT

Thanks guys!!  I verified all the problems reported in this bug.  Most of the issues have been addressed including the auto-scroll problem.  Thank you! great work!

There are only three more issues that need to be addressed:

- The height of the stereotype text box changes when items are added to it.  To reproduce this, Open the editor for an Entity artifact > Under Stereotypes, click on Add > Add a new stereotype > Save the file > notice the height of the text box changing.  If the stereotype is removed and the file is resaved, the text box readjusts to its original height.

- For the Session Facade artifact, the 'Source' page should be the last page that's displayed.  This is how it's done for all the other artifact editors. If this is too much work, don't worry about it.

- There is still another issue with the stereotype edit dialog:
Open an entity artifact editor > Add stereotype 'AlternateKey1' to it > Click on Edit > Click on the Add button twice > Click on the first value and modify it to 'value1'> Click on the second value and modify it to 'value2' (don't remove the focus out of text box) > click on OK > reselect the stereotype and click on edit > The values are displayed as:
'value1'
'<empty>'

Expected result is:
'value1'
'value2'

Comment 15 Yuri Strot

2010-10-14 14:23:20 EDT

The last few items fixed.

Comment 16 Navid Mehregani

2010-10-14 17:57:18 EDT

Thanks! Verified fix.