Bugzilla – Full Text Bug Listing
| Summary: | Unnecessary dependencies on dtd.core and emf.core | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Source Editing | Reporter: | Nick Sandonato <nsand.dev> | ||||
| Component: | wst.html | Assignee: | Nick Sandonato <nsand.dev> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Nick Sandonato <nsand.dev> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | david_williams, thatnitind | ||||
| Version: | 3.2 | Flags: | david_williams:
pmc_approved+
nsand.dev: pmc_approved? (raghunathan.srinivasan) nsand.dev: pmc_approved? (naci.dai) nsand.dev: pmc_approved? (deboer) nsand.dev: pmc_approved? (neil.hauge) nsand.dev: pmc_approved? (kaloyan) thatnitind: review+ |
||||
| Target Milestone: | 3.2.2 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | PMC_approved | ||||||
| Attachments: |
|
||||||
Nitin, would you mind giving this a review? * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. Two new dependencies were introduced unnecessarily when there was a simpler way to evaluate the same test. * Is there a work-around? If so, why do you believe the work-around is insufficient? No * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Existing unit tests were executed. * Give a brief technical overview. Who has reviewed this fix? To remove these dependencies, we rely on some of the inherent properties of the CMNode that the DTD elements were based on instead of having to invoke methods specific to the DTD element which require the dependencies. Nitin has reviewed the fix. * What is the risk associated with this fix? Should be fairly safe. I love simplifications. Not sure it's urgent for maintenance release .... but since we'll have to live with this stream for a while, is probably worth improving. Released |
Created attachment 177892 [details] patch html.ui is currently depending on dtd.core and emf.core for one piece of functionality that we can actually reproduce without these dependencies. This came to our attention today after a version increment in EMF caused some compilation errors. We'll be able to remove this dependency entirely through this fix.