Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324099

Summary: p2.user.ui feature version should be incremented in 3.6.1 stream
Product: [Eclipse Project] Equinox Reporter: Kim Moir <kim.moir>
Component: p2Assignee: P2 Inbox <equinox.p2-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: jeffmcaffer, john.arthorne
Version: 3.6.1Flags: jeffmcaffer: pmc_approved+
Target Milestone: 3.6.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch for equinox sdk none

Description Kim Moir CLA 2010-08-31 11:00:02 EDT
There are new versions of bundles in it compared to 3.6.  For instance, p2.director, p2.core, artifact.repository and touchpoint.eclipse bundles have newer versions.
Comment 1 Kim Moir CLA 2010-08-31 11:04:54 EDT
The equinox.sdk feature should also be incremented, I'll attach a patch for that change.
Comment 2 Kim Moir CLA 2010-08-31 11:07:55 EDT
Created attachment 177848 [details]
patch for equinox sdk

not sure if this needs PMC approval, if so please +1
Comment 3 Jeff McAffer CLA 2010-09-03 11:17:14 EDT
we should only have to inc the feature version number if the feature itself actually changed. changes in versions of the budnels it inlcudes should be captured in the computed version qualifier for the feature.
Comment 4 Jeff McAffer CLA 2010-09-03 11:26:19 EDT
got it.  the included bundle version numbers changed.  according to the version numbering guidelines http://wiki.eclipse.org/Version_Numbering#Versioning_features then the feature's version number should change correspondingly.

Carry on.
Comment 5 Kim Moir CLA 2010-09-03 11:38:08 EDT
The p2.user.ui feature version should also be incremented in the 3.6.1 stream, I didn't attach a patch because I don't own that feature.
Comment 6 DJ Houghton CLA 2010-09-03 13:21:11 EDT
I updated the p2.user.ui feature and tagged it but don't have the permissions to update the equinox.sdk feature. It appears to be owned by the plat-ui group. Adding John to the CC list since he is part of that group.
Comment 7 Kim Moir CLA 2010-09-03 14:08:23 EDT
DJ, I released the change for the equinox.sdk feature, I had it in my workspace anyways.
Comment 8 DJ Houghton CLA 2010-09-03 14:46:34 EDT
Closing.