Bugzilla – Full Text Bug Listing
| Summary: | edc - Registers.java writing empty "OK" messages to Error Log | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Kirk Beitz <kirk.beitz> | ||||||
| Component: | cdt-debug-edc | Assignee: | Ken Ryall <ken.ryall> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Ken Ryall <ken.ryall> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | cdtdoug, ling.5.wang | ||||||
| Version: | 7.0 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Kirk, it may be better to just use "if (! rm.isSuccess())" as the check condition. Created attachment 177786 [details] patch to check rm.isSuccess() prior to attempting to log result (In reply to comment #1) > Kirk, it may be better to just use "if (! rm.isSuccess())" as the check > condition. ok, Ling, the updated patch now reflects this. Committed the patch to head. *** cdt cvs genie on behalf of lwang *** Bug 324010: edc - Registers.java writing empty "OK" messages to Error Log [*] Registers.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/services/Registers.java?root=Tools_Project&r1=1.10&r2=1.11 |
Created attachment 177762 [details] patch to check if status is "OK" before logging to error log when operating the edc debugger, it regularly writes empty "OK" messages to the Error Log view, cluttering it unnecessarily. i tracked this to Registers.java ... see the attached patch for the suggested fix. Ling, i've CC:ed you because you are the last one to submit changes to this file. can you take this and review it and commit it to help ken from having to do so much of my commit work?