Bugzilla – Full Text Bug Listing
| Summary: | [launch] FinalLaunchSequence could throw an NPE | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Marc Khouzam <marc.khouzam> | ||||||
| Component: | cdt-debug-dsf-gdb | Assignee: | Marc Khouzam <marc.khouzam> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Marc Khouzam <marc.khouzam> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | elaskavaia.cdt, pawel.1.piech | ||||||
| Version: | 7.0 | Flags: | marc.khouzam:
review?
(elaskavaia.cdt) |
||||||
| Target Milestone: | 7.0.1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 177753 [details]
Fix for HEAD
Fix for HEAD which also merges three steps into a single one. This is better for our FinalLaunchSequence extendability effort.
Committed to HEAD.
Created attachment 177754 [details]
Fix for 7_0
Simpler fix for 7_0. Committed.
Elena, can you review? *** cdt cvs genie on behalf of mkhouzam *** Bug 323996: Avoid potential NPE [*] FinalLaunchSequence.java 1.14 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/FinalLaunchSequence.java?root=Tools_Project&r1=1.13&r2=1.14 [*] FinalLaunchSequence.java 1.11.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/FinalLaunchSequence.java?root=Tools_Project&r1=1.11.2.1&r2=1.11.2.2 |
I noticed the following code in FinalLaunchSequence: fCommandControl = fTracker.getService(IGDBControl.class); if (fCommandControl == null) { requestMonitor.setStatus(new Status(IStatus.ERROR, GdbPlugin.PLUGIN_ID, -1, "Cannot obtain control service", null)); //$NON-NLS-1$ } fCommandFactory = fCommandControl.getCommandFactory(); The last line will NPE if fCommandControl is null.