Bugzilla – Full Text Bug Listing
| Summary: | JSP translation lacks package fragment root | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Source Editing | Reporter: | Nick Sandonato <nsand.dev> | ||||
| Component: | jst.jsp | Assignee: | Nick Sandonato <nsand.dev> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Nick Sandonato <nsand.dev> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | itewksbu, matthias.b, mauromol, thatnitind | ||||
| Version: | 3.2 | Flags: | thatnitind:
review+
|
||||
| Target Milestone: | 3.2.3 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
To be clear, this is a regression, where before the source was part of a package fragment root, and currently it is not. This attached patch will add the compilation unit back to a package fragment root. This seems dependent on there being a Source folder on the build path. Do things work if there is not one? (In reply to comment #2) > This seems dependent on there being a Source folder on the build path. Do > things work if there is not one? We've always been dependent on there being a Source folder in the build path. There may be a way for us to remove this dependency, but as noted, without a package fragment root, JDT will not allow us to refactor anyway. Code checked in. Thanks, Nitin. |
Created attachment 177733 [details] patch When creating the compilation unit for a JSP translation, it's missing a package fragment root. While most functionality is still present, refactoring tends to not work due to the JDT requiring a package fragment root for the compilation unit, otherwise it thinks the source file is outside of the classpath and so the JDT Match locator skips over it.