Bugzilla – Full Text Bug Listing
| Summary: | External Tools Launch delegate no longer supports launch in background | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | James Blackburn <jamesblackburn+eclipse> | ||||||
| Component: | Ant | Assignee: | Platform-Ant-Inbox <platform-ant-inbox> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | major | ||||||||
| Priority: | P3 | CC: | daniel_megert, darin.eclipse, Michael_Rennie, patrik.andren, remy.suen | ||||||
| Version: | 3.6 | Flags: | daniel_megert:
pmc_approved+
Michael_Rennie: review+ |
||||||
| Target Milestone: | 3.6.1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Thanks for the patch James, I am curious though why that code was ever commented out. Prior to the fix for bug 264338 there was an if-then that used to honour the launch-in-background settings, and one of the patches commented it all out. Maybe Darin W can shed some light on what he was thinking at the time. Looks like this just fell through the cracks during the 3.6 refactoring to make external tool launching headless. It should be fixed, and is a regrression. Marking as 3.6.1 candidate. Created attachment 177782 [details]
patch for 3.7
*** Bug 321096 has been marked as a duplicate of this bug. *** Released to 3.7 (HEAD). Adding Dani for 3.6.1 PMC approval in RC3. (note, patch works for both 3.7 and 3.6.1). Adding Michael for review. (In reply to comment #2) > Looks like this just fell through the cracks during the 3.6 refactoring to make > external tool launching headless. It should be fixed, and is a regrression. Agree. Verified the fix and the behavior. +1 for 3.6.1 RC3. Don't forget to update the bundle version to 1.0.1. Released to 3.6.1. Updated bundle version to 1.0.1. +1 verified Verified in M20100901-1310 |
Created attachment 177718 [details] patch 1 The external tools launch delegate: ProgramLaunchDelegate#launch spins waiting until the underlying program has exited. This is different to other launch delegates, which are expected to return immediately having launched the launch configuration. As a result calls to ILaunchConfiguration#lanch doesn't return in a timely manner, only returning when the launch has been completed. Simple patch attached.