Bugzilla – Full Text Bug Listing
| Summary: | [Net] Unnecessary native method call | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Wojciech Galanciak <wojciech.galanciak> | ||||||
| Component: | Team | Assignee: | Szymon Brandys <Szymon.Brandys> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | pawel.pogorzelski1, Szymon.Brandys | ||||||
| Version: | 3.6 | Flags: | Szymon.Brandys:
review+
|
||||||
| Target Milestone: | 3.7 M3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 177709 [details]
fix
Good catch Wojciech, the fix is good. Checked in to HEAD. |
Created attachment 177708 [details] fix In ProxyManager there is an unnecessary call to select method from native provider (see attached fix). We cannot assume that two calls (one after another) will both return non-empty array so it still can throw AIOOBE. Additionally, it is less efficiently.