Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323853

Summary: GeneratorNode cannot handle version
Product: z_Archived Reporter: Carsten Reckord <reckord>
Component: BuckminsterAssignee: buckminster.core-inbox <buckminster.core-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: thomas
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch for wrong version range
none
Updated patch thomas: iplog+

Description Carsten Reckord CLA 2010-08-27 12:05:10 EDT 
If a version is set for a generator node, resolution attempts fail with 

java.lang.IllegalArgumentException: Range minimum "1.6.0.21" is not less then range maximum "1.6.0.21" (inclusion is required at both ends if the versions are equal)
at org.eclipse.equinox.p2.metadata.VersionRange.validateRange(VersionRange.java:467)
at org.eclipse.equinox.p2.metadata.VersionRange.<init>(VersionRange.java:96)
at org.eclipse.buckminster.core.metadata.model.GeneratorNode.getRequest(GeneratorNode.java:109)
Comment 1 Carsten Reckord CLA 2010-08-27 12:06:48 EDT 
Created attachment 177628 [details]
Patch for wrong version range

The GeneratorNode creates the version range as [x.x.x,x.x.x). The attached patch changes this to [x.x.x,x.x.x], which should fix this problem.
Comment 2 Carsten Reckord CLA 2010-09-03 10:05:29 EDT 
Created attachment 178150 [details]
Updated patch

A followup problem is that the property names for the generator element's version and name got mixed up. I updated the patch to fix that, too.
Comment 3 Thomas Hallgren CLA 2010-09-11 06:12:07 EDT 
Patch applied to helios-maintenance rev 11579.
Comment 4 Thomas Hallgren CLA 2010-09-11 06:12:45 EDT 
Comment on attachment 178150 [details]
Updated patch

Thanks for the patch.