Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323846

Summary: Backport Bug 287604 - IAC config file generation slow down the startup of workbench.
Product: z_Archived Reporter: Mike Melick <melickm>
Component: TPTPAssignee: Joel Cayne <jcayne>
Status: CLOSED FIXED QA Contact: Kathy Chan <kathy>
Severity: major    
Priority: P3 CC: ernest, hollisc, jcayne, jgwest, khiamt, melickm, tjbishop
Version: unspecifiedFlags: jgwest: pmc_approved? (oec)
ernest: pmc_approved+
jgwest: pmc_approved? (kathy)
jgwest: pmc_approved? (jerome.bozier)
jgwest: pmc_approved+
jgwest: review+
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch for plug-in startup from bug 287604 none

Description Mike Melick CLA 2010-08-27 11:27:04 EDT 
Build Identifier: 

This is a request to backport bugzilla 287604 in support of a large customer for our adopter product.

The customer is experiencing "hangs" of 60s or more, and one of the stacktraces captured showed this was the same issue as 287604.    

Note: I've opened this as major due to the impact to our customer. 

Reproducible: Sometimes

Steps to Reproduce:
Intermittent, but we were able to capture trace that led to this bugzilla.
Comment 1 Mike Melick CLA 2010-08-27 11:31:05 EDT 
Request the backport to 4.5.2.1 which is the next version our adopter product will pick up.
Comment 2 Joel Cayne CLA 2010-08-27 12:37:05 EDT 
Created attachment 177631 [details]
Patch for plug-in startup from bug 287604

Applies the patch from bug 287604 to TPTP 4.5.2.1 and updates the plug-in version.
Comment 3 Joel Cayne CLA 2010-08-27 12:37:27 EDT 
Jonathan,

Can you please review?

Thanks
Comment 4 Jonathan West CLA 2010-08-27 12:41:24 EDT 
Patch is good.
Comment 5 Joel Cayne CLA 2010-08-27 12:48:22 EDT 
I would like to request for PMC approval to include the fix of this bug in TPTP
v4.5.2.1.

1.   Explain why you believe this is a stop-ship defect. How does the defect
manifest itself, and how will users of TPTP / consuming products be affected if
the defect is not fixed?

Removes the IAC configuration during plug-in startup.

2. Is there a work-around? If so, why do you believe the work-around is
insufficient?

No.

3. Is this a regression or API breakage? Explain.

No.

4. Does this require new API?

n/a

5. Who performed the code review?

Jonathan

6. Is there a test case attached to the bugzilla record?

n/a

7. What is the nature of the fix? What is the scope of the fix? What is the
risk associated with this fix?

Low. Removes configuration during startup. The change is already included in TPTP 4.6.2.

8. Is this fix related to any standards that TPTP adheres to? If so, who has
validated that the fix continues to adhere to the standard?
n/a
Comment 6 Jonathan West CLA 2010-08-27 12:54:37 EDT 
Requesting approval for TPTP 4.5.2.1. This is a major issue being faced by a customer, and a fix is needed for 4.5.2.1.
Comment 7 Joel Cayne CLA 2010-08-27 13:03:22 EDT 
Patch checked into TPTP 4.5.2.1 branch with Project and PMC approval.
Comment 8 Ernest Mah CLA 2010-08-27 13:07:25 EDT 
The code in question performs work that should not vary between runs.  This leads me to believe that the startup code in and of itself would not be the culprit for intermittent UI hangs of 60s.

Nevertheless, it is code that doesn't need to be in startup.  The change is simple and has been tested since 4.6.2.
Comment 9 Kathy Chan CLA 2011-02-11 13:45:43 EST 
This defect had been resolved as FIXED for more than 1 month.  Please verify with the latest TPTP 4.7.2 driver.  If this defect is still left unverified by February 25, we'll close it on the originator's behalf.

TPTP 4.7.2 driver can be downloaded from:

http://www.eclipse.org/tptp/home/downloads/?ver=4.7.2
Comment 10 Mike Melick CLA 2011-03-15 10:59:08 EDT 
Closing this, as it was an intermittent issue which I have not seen since the change was picked up.