Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323821

Summary:	[api] Push down StringVariableSelectionDialog
Product:	[Eclipse Project] Platform	Reporter:	Martin Oberhuber <mober.at+eclipse>
Component:	Debug	Assignee:	Platform-Debug-Inbox <platform-debug-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	daniel_megert, darin.eclipse, eclipse, john.arthorne, pawel.1.piech, remy.suen
Version:	3.7	Keywords:	api
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:	stalebug

Description Martin Oberhuber

2010-08-27 09:24:09 EDT

The StringVariableSelectionDialog provides UI access to the Variable substitution mechanism provided by org.eclipse.core.variables .

This variable substitution mechanism is universally applicable. But having the related UI live in org.eclipse.debug.ui forces clients to either live with a dependency to debug.ui, or clone (fork) the StringVariableSelectionDialog.
 
This has happened in CDT, for instance, which ships its own forked copy of the dialog in org.eclipse.cdt.ui; similar reasoning forced us to recently fork the StringVariableSelectionDialog in our commercial product on top of Eclipse.

In order to avoid more forking, the StringVariableSelectionDialog should be pushed down. Doing a "Find References" on o.e.core.variables reveals that
   org.eclipse.ui.console
already depends on it; whereas o.e.ui and o.e.ui.ide do not yet have any reference. So, pushing down into org.eclipse.ui.console seems like one possibility, creating a separate new plugin (org.eclipse.ui.variables) is another one.

Comment 1 Martin Oberhuber

2010-08-27 09:29:21 EDT

PS in case org.eclipse.ui can live with a core.variables dependency, that would of course also be a good place for the StringVariableSelectionDialog to live in.

Comment 2 Darin Wright

2010-08-30 12:38:56 EDT

John, do you have any opinion on where the dialog should live? I.e. its own bundle vs. org.eclipse.ui?

Comment 3 Pawel Piech

2011-06-08 13:09:28 EDT

We won't be able to remove the existing StringVariableSelectionDialog, but we can deprecated it if UI copies it.

Comment 4 Dani Megert

2011-06-09 09:05:18 EDT

The core layer which introduces the variables concept is from Debug, hence the UI can't come from the general Platform UI layer. It has to be provided by Platform Debug, e.g. in org.eclipse.variables.ui. However, adding a separate bundle for just one class is definitely overkill.

Comment 5 Pawel Piech

2011-06-09 10:44:46 EDT

(In reply to comment #4)
> The core layer which introduces the variables concept is from Debug, hence the
> UI can't come from the general Platform UI layer. It has to be provided by
> Platform Debug, e.g. in org.eclipse.variables.ui. However, adding a separate
> bundle for just one class is definitely overkill.

Duh, of course :-)  There's a few other interfaces classes related to variables, namely the org.eclipse.debug.internal.ui.stringsubstitution package.

Comment 6 Lars Vogel

2019-11-14 03:31:36 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.