Bug 323814

Description Dennis Hendriks 2010-08-27 08:47:30 EDT

Build Identifier: Build id: 20100617-1415 (Helios)

I have a plug-in that contributes an action. Executing the action prints some output to a console. The console is created the first time, and reused each next command execution. Each time a new message stream is created, and the console is cleared. 20 lines of output are printed to the console. The first time there is one empty lines after the printed lines, the next time, there are two, the next time three, etc...

Reproducible: Always

Steps to Reproduce:
Steps To Reproduce:
1. Create a Hello World Command plugin project. Call the handler "TestHandler" and set the package to "testplugin.handlers".
2. Replace the handler code with the code below.
3. Run the plugin.
4. Select the "Sample Command" from the "Sample Menu" (or use ctrl+6 shortcut). Do this a bunch of times.
5. Observe how each time, the console gets more empty lines after the output.

Code:

package testplugin.handlers;

import org.eclipse.core.commands.AbstractHandler;
import org.eclipse.core.commands.ExecutionEvent;
import org.eclipse.core.commands.ExecutionException;

import org.eclipse.ui.console.ConsolePlugin;
import org.eclipse.ui.console.IConsole;
import org.eclipse.ui.console.IConsoleManager;
import org.eclipse.ui.console.MessageConsole;
import org.eclipse.ui.console.MessageConsoleStream;

public class TestHandler extends AbstractHandler {

    private static final String PLUGIN_CONSOLE_NAME = "Test";

    public Object execute(ExecutionEvent event) throws ExecutionException {
        MessageConsoleStream console = getConsole(true);
        for (int i = 0;i<20;i++){
            console.println("Plugin command output...");
        }
        return null;
    }

    public static MessageConsole findConsole(String name) {
        ConsolePlugin plugin = ConsolePlugin.getDefault();
        IConsoleManager conMan = plugin.getConsoleManager();
        IConsole[] existing = conMan.getConsoles();
        for (int i = 0; i < existing.length; i++)
            if (name.equals(existing[i].getName()))
                return (MessageConsole) existing[i];
        // no console found, so create a new one
        MessageConsole myConsole = new MessageConsole(name, null);
        conMan.addConsoles(new IConsole[] { myConsole });
        return myConsole;
    }

    public static MessageConsoleStream getConsole(boolean clearConsole) {
        MessageConsole myConsole = findConsole(PLUGIN_CONSOLE_NAME);
        myConsole.activate();
        MessageConsoleStream out = myConsole.newMessageStream();
        if (clearConsole) {
            myConsole.clearConsole();
        }
        return out;
    }
}