Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323781

Summary: [build] provide UI for setting build parameters
Product: z_Archived Reporter: Steffen Pingel <steffen.pingel>
Component: MylynAssignee: Eike Stepper <stepper>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 Keywords: contributed
Version: unspecified   
Target Milestone: 0.7   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 323568    
Attachments:
Description Flags
Patch v1 - crude ParametersDialog, functional
steffen.pingel: iplog+
screenshot none

Description Steffen Pingel CLA 2010-08-27 01:06:21 EDT
If running plans requires additional parameters the user should be prompted to provide these (see bug 323568).
Comment 1 Eike Stepper CLA 2010-08-27 02:19:25 EDT
Created attachment 177586 [details]
Patch v1 - crude ParametersDialog, functional
Comment 2 Eike Stepper CLA 2010-08-27 02:21:49 EDT
I confirm that I'm the only author of the contributed patch and that I apply the EPL to this contribution.
Comment 3 Steffen Pingel CLA 2010-08-27 03:32:33 EDT
Created attachment 177590 [details]
screenshot
Comment 4 Steffen Pingel CLA 2010-08-27 03:33:57 EDT
Great stuff! I have applied the patch with minor changes to tweak the dialog a little bit.
Comment 5 Eike Stepper CLA 2010-08-27 04:13:20 EDT
(In reply to comment #4)
> Great stuff! 

Thanks ;-)

> I have applied the patch with minor changes to tweak the dialog a
> little bit.

Yeah, the IParameterDefinition.description should be shown somewhere.

And the creation of the parameters Map in okPressed is also sub-optimal. Should use the parameter types and not the control types. Maybe we can move the whole value-handling into the implementations of IParameterDefinition...