Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323713

Summary: [DND] Drop affordance drawn in minimized stack but throws IAE when mouse button is released
Product: [Eclipse Project] Platform Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Eric Moffatt <emoffatt>
Status: VERIFIED FIXED QA Contact: Eric Moffatt <emoffatt>
Severity: normal    
Priority: P3    
Version: 3.6   
Target Milestone: 3.7 M4   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Prevent the IAE none

Description Remy Suen CLA 2010-08-26 10:28:27 EDT 
M20100825-0800

1. Minimize the 'Package Explorer'.
2. Drag the 'Problems' view so that your mouse cursor is below the icon of the 'Package Explorer' in the left trim.
3. Release your mouse button.
4. The view doesn't actually get moved to the trim.
5. An IAE is logged.

java.lang.IllegalArgumentException: Argument cannot be null
at org.eclipse.swt.SWT.error(SWT.java:4064)
at org.eclipse.swt.SWT.error(SWT.java:3998)
at org.eclipse.swt.SWT.error(SWT.java:3969)
at org.eclipse.swt.widgets.Widget.error(Widget.java:468)
at org.eclipse.swt.widgets.ToolBar.indexOf(ToolBar.java:651)
at org.eclipse.ui.internal.FastViewDnDHandler$ViewDropTarget.drop(FastViewDnDHandler.java:87)
at org.eclipse.ui.internal.dnd.DragUtil.performDrag(DragUtil.java:134)
at org.eclipse.ui.internal.PartStack.paneDragStart(PartStack.java:1751)
at org.eclipse.ui.internal.PartStack.dragStart(PartStack.java:1703)
at org.eclipse.ui.internal.PartStack.access$0(PartStack.java:1694)
at org.eclipse.ui.internal.PartStack$1.dragStart(PartStack.java:125)
at org.eclipse.ui.internal.presentations.util.TabbedStackPresentation$1.handleEvent(TabbedStackPresentation.java:118)
at org.eclipse.ui.internal.presentations.util.AbstractTabFolder.fireEvent(AbstractTabFolder.java:269)
at org.eclipse.ui.internal.presentations.util.AbstractTabFolder.fireEvent(AbstractTabFolder.java:282)
at org.eclipse.ui.internal.presentations.util.AbstractTabFolder.handleDragStarted(AbstractTabFolder.java:366)
at org.eclipse.ui.internal.presentations.util.AbstractTabFolder$2.handleEvent(AbstractTabFolder.java:67)
at org.eclipse.ui.presentations.PresentationUtil.handleMouseMove(PresentationUtil.java:110)
at org.eclipse.ui.presentations.PresentationUtil.access$4(PresentationUtil.java:95)
at org.eclipse.ui.presentations.PresentationUtil$2.handleEvent(PresentationUtil.java:63)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4066)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3657)
Comment 1 Eric Moffatt CLA 2010-08-31 15:43:16 EDT 
Exists in 3.4...
Comment 2 Eric Moffatt CLA 2010-11-09 10:22:07 EST 
Created attachment 182726 [details]
Prevent the IAE


Doesn't address the fact that there's a drop affordance that doesn't work...I'll look into that as part of bug 323729.
Comment 3 Eric Moffatt CLA 2010-11-09 10:23:04 EST 
Committed in >20101109. Applied the patch.
Comment 4 Eric Moffatt CLA 2010-12-07 11:02:55 EST 
Verified in I20101206-1800.