Bug 323704

Description aytac 2010-08-26 09:17:05 EDT

Build Identifier: M20090917-0800


I have a custom project wizard which creates a given number of projects. If the wizard is canceled during the creation of projects, I want to delete the projects which are created between pressing the finish and cancel buttons. So, I call the newProjects[i].delete() in a for loop when cancel is pressed. Projects are deleted from the workspace but, sometimes they are still visible in project explorer. when i refresh project explorer manually they dissappear. In package explorer it works fine. My eclipse version is 3.5.1

I debugged and saw that sometimes, projects are deleted before they are added to the elementMap of the viewer. So, in AbstractTreeViewr's internalRemove(Object[]) method elements can't be found and the widgets for the deleted projects aren't disposed. It seems a syncronization problem.

After adding/deleting resources processDelta method In ResourceExtensionContentProvider class is called for the updates. If we are not in UI thread, runUpdates in Display.asyncExec(). When syncExec is used in stead of asyncExec the problem is resolved. But I don't know why asyncExec is used and what if change it to syncExec.

	protected void processDelta(IResourceDelta delta) {		

		Control ctrl = viewer.getControl();
		if (ctrl == null || ctrl.isDisposed()) {
			return;
		}
		final Collection runnables = new ArrayList();
		processDelta(delta, runnables);

		if (runnables.isEmpty()) {
			return;
		}

		//Are we in the UIThread? If so spin it until we are done
		if (ctrl.getDisplay().getThread() == Thread.currentThread()) {
			runUpdates(runnables);
		} else {
			ctrl.getDisplay().asyncExec(new Runnable(){
				public void run() {
					Control ctrl = viewer.getControl();
					if (ctrl == null || ctrl.isDisposed()) {
						return;
					}
					
					runUpdates(runnables);
				}
			});
		}

	}


Reproducible: Sometimes