Bugzilla – Full Text Bug Listing
| Summary: | Service Interface and Data Types Editors source code and code coverage | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Dimitar Tenev <dimitar.tenev> | ||||||
| Component: | WTP Incubator | Assignee: | Project Inbox <wtp.inc-inbox> | ||||||
| Status: | NEW --- | QA Contact: | David Carver <d_a_carver> | ||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | CC: | dimitar.donchev, dimitar.tenev, d_a_carver, eclipse, emil.simeonov, georgi.konstantinov, kaloyan, mistria, nevena.manova | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows Vista | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 177515 [details]
HTML file with current JUnits codecoverage.
Created attachment 177518 [details]
SIE/DTE plugins, and JUnits plugin
Hi Colleagues, Please noticed that the package names are not refactored yet (e.g. they contain com.sap). This will be done prior submiting the code to incubator. Best regards, Dimitar One question, I have in regards to this whole process. The WTP Incubator code and components that reside there have recently moved to git as the repository for the wtp incubator. See the browseable repository below. http://git.eclipse.org/c/webtools/org.eclipse.webtools.incubator.git/ Now there resides an old CVS module for the incubator as well, in the webtools directory, but this is for all intents and purposes deprecated and none of the existing incubating projects are using it. So, the question is where is the code going to reside. Also, what build system and technology are you going to use. The custom build system of WTP (which currently doesn't support git), or another build system like Buckminster, Maven 3/Tycho, etc. (As a note currently all the existing incubator projects are using Maven 3/Tycho, but you can choose what you want to use). I'm assuming based on the proposal that when this does graduate it will reside in either the Web Services project or Java EE? Dave, I'll take these questions. The project will most probably use CVS instead of Git. The only reason for this is the access through the firewall from our office. We have well-established practice to access CVS through proxy.eclipse.org, but I haven't found a way to access Git yet. Do you have any helpers for this? By the way, the JPA Diagram Editor project that SAP started recently in the WTP Incubator uses CVS, too. For the same reason. About the build system. I would advise these guys to use Hudson/Maven/Tycho setup - like all other WTP Incubator projects. The graduation target is SSE and Webservices projects. (In reply to comment #5) > Dave, I'll take these questions. > > The project will most probably use CVS instead of Git. The only reason for this > is the access through the firewall from our office. We have well-established > practice to access CVS through proxy.eclipse.org, but I haven't found a way to > access Git yet. Do you have any helpers for this? If we need to have http/https access to the git repository, we just need to open a bug request with the webmasters. > > By the way, the JPA Diagram Editor project that SAP started recently in the WTP > Incubator uses CVS, too. For the same reason. > > About the build system. I would advise these guys to use Hudson/Maven/Tycho > setup - like all other WTP Incubator projects. One thing about the Maven based builds is they don't currently integrate well with the existing WTP build and release structure. I'm in the process of getting the necessary items setup for promoting these to the download site when necessary. This work is happening in one of the Xquery incubator bug reports. I would encourage both of the SAP incubator projects to consider moving to git, so that we have a common place for users to retrieve the code. The other purpose was to allow us to learn what possible issues still need to be addressed in the Egit plugin as well as what are the possible build issues that can occur. Also what are the best ways to handle development and releases, so that when the main WTP tools decide (if they decide) to migrate we have most everything worked out ahead of time. (In reply to comment #6) > If we need to have http/https access to the git repository, we just need to > open a bug request with the webmasters. I see. I only consulted wiki pages until now. You are right - I found relevant bugs reported to the webmaster and successfully connected to the MPC git repo. We will consider Git - SAP is actively investing in this technology. Thanks! > One thing about the Maven based builds is they don't currently integrate well > with the existing WTP build and release structure. I'm in the process of > getting the necessary items setup for promoting these to the download site when > necessary. This work is happening in one of the Xquery incubator bug reports. Good to know. However, this issue should not stop us since it is so easy to setup the maven/tycho build - especially, when copy-pasting from the XQuery pom.xml files :-) (In reply to comment #2) The code looks good. Especially the test coverage is great. :-) Could you please add the Eclipse Public License to each plug-in and add the EPL info header to each Java file. I don't know if this has to be done before IP. (In reply to comment #8) > (In reply to comment #2) > > The code looks good. Especially the test coverage is great. :-) > > Could you please add the Eclipse Public License to each plug-in and add the EPL > info header to each Java file. I don't know if this has to be done before IP. No that doesn't have to be done before IP. But IP is going to request it when the code is submitted for review. Correct - the IP review will request these headers. Here is the template and instructions: http://www.eclipse.org/legal/copyrightandlicensenotice.php What is the status of this contribution. According to http://wiki.eclipse.org/WTP/Service_Interface_and_Data_Types_Editors/Proposal it should be part of Indigo... Hi Micael, The project is not part of Indigo. At the moment we are cleaning up some bugzillas. However you may try it at your own by following the instructions on the Wiki page: http://wiki.eclipse.org/Service_Interface_and_Data_Types_Editors Best regards, Dimitar |
Hi Colleagues, This enhancement contains "Service Interface and Data Types Editors" (SIE/DTE) plugins, and their JUnits. 1. How to import the plugins We have exported "Service Interface and Data Types Editors" (SIE/DTE) plugins in an archive sie_contrib.zip. You may Import it as existing projects into your workspace. To run SIE/DTE in runtime workbench you have to add the following VM arguments in your Debug/Run Configuration: -XX:PermSize=32m -XX:MaxPermSize=256m 2. How to run SIE/DTE Junits To run SIE/DTE Junits do run the tests suite (as JUnit Plug-in Test): com.sap.tc.esmp.tools.sieditor.test.all.AllTestSuites Running this sute will require the following VM arguments in your Debug/Run Configuration: -XX:PermSize=32m -XX:MaxPermSize=256m Please do notice that one JUnit test fails because of a bug, on which we are working on. 3. How to see the current codecoverage We have measured JUnits code coverage with eclemma, and attached results as archived html file sie_cc.zip 4. Attachements: Archive sie_contrib.zip contains: - SIE/DTE plugins - esmp.tools__com.sap.tc.esmp.tools.sieditor.core_nwed003_stream esmp.tools__com.sap.tc.esmp.tools.sieditor.fwk_nwed003_stream esmp.tools__com.sap.tc.esmp.tools.sieditor.model_nwed003_stream esmp.tools__com.sap.tc.esmp.tools.sieditor.ui_nwed003_stream - SIE/DTE Junit tests plugin - esmp.tools__com.sap.tc.esmp.tools.sieditor.test_nwed003_stream Archive sie_cc.zip contains: HTML file with current JUnits codecoverage. Best regards, Dimitar