Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323689

Summary:

refactoring operations need an entry point to put operations at the very end

Product:

z_Archived

Reporter:

Bozier jerome <jerome.bozier>

Component:

TPTP

Assignee:

Bozier jerome <jerome.bozier>

Status:

CLOSED FIXED

QA Contact:

Kathy Chan <kathy>

Severity:

major

Priority:

CC:

alexberns, paulslau

Version:

unspecified

Flags:

paulslau: review+

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

adopter

Attachments:

Description	Flags
patch	none

Description Bozier jerome

2010-08-26 05:28:53 EDT

user product have proxy node that use EMF framework
when trying to update theses proxy that reference resources, all resource must have finished their physical action to be in good location with good name (EMF often load theses resource to update the model)
so, we need an entry point so that theses update operations can be run when all resources are physically copied/pasted/moved/renamed

inside TPTP, theses "final" update are performed inside a general EMFRefactoringTransaction. this mechanism is totally internal and closed to user product.
we have to add an extension point mechanism so that user can declare their own final actions to be performed

Comment 1 Alex Bernstein

2010-08-27 12:59:32 EDT

We need to fix this. This is important.

Comment 2 Bozier jerome

2010-09-03 07:03:26 EDT

Created attachment 178129 [details]
patch

this patch add new API for EMFRefactoringTransaction

it add theses 2 methods :
. public void addCustomChange(Change change)
=> allow user to add a custom change

. public List<Change> getCustomChanges()
=> allow user to retrieve the list of all custom change

theses custom change will be performed at end of EMFRefactoringTransaction commit part
with theses entry points, user that have their own EMF change to be performed to update their EMF model when all physical change have already been done (so that any resource loading made by EMF will not fail)

Comment 3 Bozier jerome

2010-09-03 07:04:08 EDT

Paul, could you please review this small patch ?

many thanks to you

Comment 4 Paul Slauenwhite

2010-09-03 07:23:16 EDT

Reviewed and approved with comments:

-Please make the new methods @provisional.

Comment 5 Paul Slauenwhite

2010-09-10 14:40:50 EDT

Note, this may have been resolved by defect 324996.  Please confirm.

Comment 6 Bozier jerome

2010-10-11 06:24:56 EDT

324996 is necessary but not enough, we have to deliver also this patch

Comment 7 Bozier jerome

2010-10-26 10:40:00 EDT

patch pushed under 4.7.2 CVS

closing

Comment 8 Kathy Chan

2011-02-11 13:46:01 EST

This defect had been resolved as FIXED for more than 1 month.  Please verify with the latest TPTP 4.7.2 driver.  If this defect is still left unverified by February 25, we'll close it on the originator's behalf.

TPTP 4.7.2 driver can be downloaded from:

http://www.eclipse.org/tptp/home/downloads/?ver=4.7.2

Comment 9 Bozier jerome

2011-04-04 09:41:05 EDT

closing