Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323599

Summary:

"Goto declaration" goes to non const member from const function.

Product:

[Tools] CDT

Reporter:

Vasiliy Dybala <dibalavs>

Component:

cdt-parser

Assignee:

Markus Schorn <mschorn.eclipse>

Status:

RESOLVED FIXED

QA Contact:

Mike Kucera <mikekucera>

Severity:

normal

Priority:

Version:

7.0

Target Milestone:

7.0.1

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
testcase + fix	mschorn.eclipse: iplog-
improved fix + testcase	mschorn.eclipse: iplog-

Description Vasiliy Dybala

2010-08-25 08:07:09 EDT

class iterator;
class const_iterator;

class container
{
public:
  iterator* begin();
  const_iterator* begin() const;
};

struct test
{
	void test_func() const
	{
		cnt.begin();
	}

	container cnt;
};

1. move cursor to cnt.begin(); and choose goto declaration.

cursor will move to  "iterator* begin();" instead "const_iterator* begin() const;"


-- Configuration Details --
Product: Eclipse 1.3.0.20100617-0520 (org.eclipse.epp.package.cpp.product)
Installed Features:
 org.eclipse.platform 3.6.0.v20100602-9gF78GpqFt6trOGhL60z0oEx3fz-JKNwxPY

Comment 1 Markus Schorn

2010-08-25 08:25:18 EDT

Thanks, I suspect that we fail to compute the correct expression type for the id-expression 'cnt'.

Comment 2 Markus Schorn

2010-08-25 09:29:27 EDT

Created attachment 177415 [details]
testcase + fix

Comment 3 Markus Schorn

2010-08-25 10:04:56 EDT

Created attachment 177423 [details]
improved fix + testcase

Improved patch takes into account whether the field is mutable or not.

Comment 4 Markus Schorn

2010-08-25 10:24:29 EDT

Fixed in 7.0.1 and 8.0 > 20100825.

Comment 5 CDT Genie

2010-08-25 11:23:04 EDT

*** cdt cvs genie on behalf of mschorn ***
Bug 323599: Type of id-expression denoting a field access.

[*] CPPASTIdExpression.java 1.24.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTIdExpression.java?root=Tools_Project&r1=1.24&r2=1.24.2.1
[*] CPPASTFieldReference.java 1.30.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTFieldReference.java?root=Tools_Project&r1=1.30&r2=1.30.2.1

[*] AST2CPPTests.java 1.345.2.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2CPPTests.java?root=Tools_Project&r1=1.345.2.2&r2=1.345.2.3

[*] AST2CPPTests.java 1.356 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2CPPTests.java?root=Tools_Project&r1=1.355&r2=1.356

[*] CPPASTIdExpression.java 1.26 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTIdExpression.java?root=Tools_Project&r1=1.25&r2=1.26
[*] CPPASTFieldReference.java 1.33 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTFieldReference.java?root=Tools_Project&r1=1.32&r2=1.33