Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323531

Summary: [Compatibility] <enabledWhen> definitions for handlers are always ignored
Product: [Eclipse Project] e4 Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Paul Webster <pwebster>
Severity: normal    
Priority: P3 CC: eiswind, pwebster
Version: 1.0   
Target Milestone: 4.1 M5   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
enabledWhen handling patch v1
none
enabledWhen handling patch v2
none
enabledWhen handling patch v3
none
enabledWhen handling patch v4 none

Description Remy Suen CLA 2010-08-24 14:18:32 EDT 
Ctrl+W should only be enabled if there's an editor. However, this is not the case and it ends up always being enabled.
Comment 1 Remy Suen CLA 2010-08-24 14:58:05 EDT 
Created attachment 177355 [details]
enabledWhen handling patch v1

We spawn EvaluationReferences that use the context but never actually track them. :o
Comment 2 Remy Suen CLA 2010-08-24 14:58:39 EDT 
Paul, can you take a look at this?
Comment 3 Remy Suen CLA 2010-10-12 16:58:21 EDT 
Created attachment 180711 [details]
enabledWhen handling patch v2

Updated to consider latest changes from bug 327585 and other changes in the compatibility layer since the original patch.
Comment 4 Remy Suen CLA 2011-01-10 12:31:29 EST 
Created attachment 186406 [details]
enabledWhen handling patch v3

Updated against HEAD.
Comment 5 Remy Suen CLA 2011-01-10 13:20:24 EST 
Created attachment 186408 [details]
enabledWhen handling patch v4

Deleted a line that was causing the evaluation to be evaluated twice when the expression was first added to the service.
Comment 6 Remy Suen CLA 2011-01-10 13:21:29 EST 
(In reply to comment #5)
> Created attachment 186408 [details]
> enabledWhen handling patch v4

Fix released to HEAD.
Comment 7 Remy Suen CLA 2011-01-26 07:58:43 EST 
Verified with I20110125-2200 on Windows XP that spamming Ctrl+W will no longer fill up the error log.