Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323436

Summary:	SelectionProviderStrategies cannot guarentee order
Product:	[WebTools] Java Server Faces	Reporter:	Gerry Kessler <gerry.kessler>
Component:	JSF Tools	Assignee:	Gerry Kessler <gerry.kessler>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	david_williams, raghunathan.srinivasan
Version:	3.2	Flags:	david_williams: pmc_approved+ raghunathan.srinivasan: pmc_approved? (naci.dai) raghunathan.srinivasan: pmc_approved? (deboer) raghunathan.srinivasan: pmc_approved? (neil.hauge) raghunathan.srinivasan: pmc_approved? (kaloyan) raghunathan.srinivasan: pmc_approved? (raghunathan.srinivasan) raghunathan.srinivasan: review+
Target Milestone:	3.2.2
Hardware:	PC
OS:	Windows XP
Whiteboard:	PMC_approved

Description Gerry Kessler

2010-08-23 15:57:24 EDT

This bug was split out from bug 321039.

Can't guarantee the extended LocatorProvider will be picked up each time 
   In the CompositeFactorySelectionStrategyProvider.getFactoryToUse() method in
JSFAppConfigManagerFactory.java, it calls providerSelector.perform(project)
method. In the perform() method, it uses an iterator for a HashMap to find the
first LocatorProvider. If DefaultJSFAppConfigManagerProviderStrategy is
searched before ExtensionBasedJSFAppConfigManagerProviderStrategy, the
DefaultProvider instead of my extended LocatorProvider will be returned.

Comment 1 Gerry Kessler

2010-08-24 13:35:05 EDT

Checked into HEAD (3.2.2 and 3.3)

Comment 2 Raghunathan Srinivasan

2010-08-27 14:31:22 EDT

* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such. 
See description
* Is there a work-around? If so, why do you believe the work-around is
insufficient? 
None
* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added? 
Manual
* Give a brief technical overview. Who has reviewed this fix? 
See description
* What is the risk associated with this fix? 
none-low

Comment 3 Raghunathan Srinivasan

2010-08-27 14:31:51 EDT

This failed to make this week's build because of spurious junit failures in
local testing.