Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323407

Summary:	EditorPane maximized state should be per workbench window
Product:	[Eclipse Project] Platform	Reporter:	Randy Hudson <hudsonr>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	remy.suen
Version:	3.6
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:

Description Randy Hudson

2010-08-23 12:22:58 EDT

The editorpane is special because it is part of nearly every perspective. When I switch perspectives, e.g. JDT-->Debug, it's because I want to see the debug perspective's views, not because I want to maximize the editor pane (since that can be done in any perspective).  So, for the debug perspective to have its own "isEditorPaneMaximized" setting is annoying.  If the last time I was in that perspective I maximized the editor pane, it's highly likely that I want it to remember that when returning.

Editor maximized setting should be a property of the workbench window, not each perspective.  When a perspective that is switched to, and that perspective is showing editors, the property should always get set to false.

Comment 1 Remy Suen

2010-08-23 17:55:31 EDT

(In reply to comment #0)
> If the last time I was in that
> perspective I maximized the editor pane, it's highly likely that I want it to
> remember that when returning.

Right now this is what happens, it remembers.

> Editor maximized setting should be a property of the workbench window, not each
> perspective.  When a perspective that is switched to, and that perspective is
> showing editors, the property should always get set to false.

I don't think I follow. You want it to be a window-specific property but you also want it to automatically go to 'false' if you switch perspectives?

Comment 2 Randy Hudson

2010-08-24 11:09:58 EDT

(In reply to comment #1)
> Right now this is what happens, it remembers.

This is request for different (smarter?) behavior.

> I don't think I follow. You want it to be a window-specific property but you
> also want it to automatically go to 'false' if you switch perspectives?

Ok, you got me.  It wouldn't matter if the property were per window or per perspective. Either way, my argument is this: I'm switching to a perspective to see its views.  If the editorpane was maximized when I was last using that perspective, set maximized to false.

So, you wouldn't have to change the property to be per window.

The only time you wouldn't set the perspective back to non-maximized editorpane is when leaving a perspective which had no editorpane. Also, maybe when closing the active perspective.

Comment 3 Eric Moffatt

2010-08-24 14:42:45 EDT

Randy, I don't think that this is a good idea. I see your point about switching perspectives allowing access to particular views but that's orthogonal to whether the EA is maximized or not, the views are accessible even with the EA max'd.

Consider this scenario:

I'm debugging (with the EA max'd because I need to see the source)

I switch to the Synchronize perspective to check out what code I've changed (note that my brain is still 'debugging', I'm just quickly checking what I've busted...;-).

I switch back to continue debugging...*I* certainly don't want me EA to be un-maximized...

It is generally a bad idea to magically switch states on a user once they've done a specific gesture indicating their desired state. The only exception I've made is to un-max the EA if all the editors are closed but I had to be convinced that that behavior was logical first. In this case I think I'd get soundly flamed were I to make this the 'normal' behavior...