Bug 323278

Description Tim Black 2010-08-20 14:10:01 EDT

Build Identifier: 20100617-1415

I have some void functions that return the value from other void functions, and the indexer erroneously reports "return has value, in function returning void" in some cases. The compiler of course is fine with this, so when I compile, the Problem window clears. But when the indexer runs again, they come back. This problem seems to happen only when the inner void function is defined in another file.

On the cdt-dev list, kesselhaus added: 
Even though the code was C++, but in C the failure is actually correct:
"A return statement with an expression shall not appear in a function whose return type is void. A return statement without an expression shall only appear in a function whose return type is void."


Reproducible: Always

Steps to Reproduce:
1. add defs (see below) to a .h file and let the indexer run.
2. wait for "return has value, in function returning void" to appear in problems view.

These defs in a .h cause the error:

#include <vector>
using std::vector;
    template <class T>
    class MyVector {
      private:
        vector<int> m_v;
      public:
        MyVector() : m_v() {}
        void push_back(T t) { return m_v.push_back(t); }  // "Return has value, in function returning void"
    };

But this in a .h does not:

    template <class T>
    class MyClass {
        void foo() { return goo(); }
        void goo() {}
    };

And this in a .cpp does not:

void goo() { }
void foo() {
  return goo();
}