Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323262

Summary: [dstore] zos shell does not display [ ] brackets properly
Product: [Tools] Target Management Reporter: Violaine Batthish <batthish>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: ankitp, dmcknigh, kjdoyle
Version: unspecifiedFlags: kjdoyle: review+
Target Milestone: 3.2.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 329443    
Attachments:
Description Flags
patch to use IBM-1047 on z, rather than cp037 none

Description Violaine Batthish CLA 2010-08-20 11:11:45 EDT
Build Identifier: RSE Core 3.2 (20100607-1030), Eclipse RCP I20100608-0911

Reported by RDz customer, and reproduced:
When using the shell on a z/OS Unix subsystem, the [ ] brackets are not displayed correctly in the shell.

As discussed with Dave McKnight, there is a hard coded codepage for system z (cp0037) which seems to be causing this problem.  The code should instead query to see if dstore.stdin.encoding is set and then use the appropriate encoding (not exactly sure - but Dave mentioned IBM-1047) 

Reproducible: Always

Steps to Reproduce:
To reproduce:
1. Start the shell
2. Enter the following command
     echo $ [ 123 + 321 ]

Expected result:
$ [ 123 + 321 ]

Actual result:
$ Ý 123 + 321 ¨

Not sure if corrupted chars will appear but [ becomes a weird Y with a slash, and the ] becomes 2 dots
Comment 1 David McKnight CLA 2010-08-20 11:23:46 EDT
Created attachment 177105 [details]
patch to use IBM-1047 on z, rather than cp037

On z, we're using IBM-1047 for reading the shell so we should be using that to write to the shell as well.
Comment 2 David McKnight CLA 2010-08-20 11:24:23 EDT
Kevin, could you review this patch?  Thanks.
Comment 3 Kevin Doyle CLA 2010-08-23 11:04:17 EDT
Review +.
Comment 4 David McKnight CLA 2010-08-23 15:01:16 EDT
Thanks. I've committed the change to cvs.