| Summary: | [dstore] zos shell does not display [ ] brackets properly | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] Target Management | Reporter: | Violaine Batthish <batthish> | ||||
| Component: | RSE | Assignee: | David McKnight <dmcknigh> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Martin Oberhuber <mober.at+eclipse> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | ankitp, dmcknigh, kjdoyle | ||||
| Version: | unspecified | Flags: | kjdoyle:
review+
|
||||
| Target Milestone: | 3.2.1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 329443 | ||||||
| Attachments: |
|
||||||
Created attachment 177105 [details]
patch to use IBM-1047 on z, rather than cp037
On z, we're using IBM-1047 for reading the shell so we should be using that to write to the shell as well.
Kevin, could you review this patch? Thanks. Review +. Thanks. I've committed the change to cvs. |
Build Identifier: RSE Core 3.2 (20100607-1030), Eclipse RCP I20100608-0911 Reported by RDz customer, and reproduced: When using the shell on a z/OS Unix subsystem, the [ ] brackets are not displayed correctly in the shell. As discussed with Dave McKnight, there is a hard coded codepage for system z (cp0037) which seems to be causing this problem. The code should instead query to see if dstore.stdin.encoding is set and then use the appropriate encoding (not exactly sure - but Dave mentioned IBM-1047) Reproducible: Always Steps to Reproduce: To reproduce: 1. Start the shell 2. Enter the following command echo $ [ 123 + 321 ] Expected result: $ [ 123 + 321 ] Actual result: $ Ý 123 + 321 ¨ Not sure if corrupted chars will appear but [ becomes a weird Y with a slash, and the ] becomes 2 dots